Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: SwiftUI custom redact #4392

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Update ContentView.swift

5bc4277
Select commit
Loading
Failed to load commit list.
Open

ref: SwiftUI custom redact #4392

Update ContentView.swift
5bc4277
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 4, 2024 in 1s

91.442% (-0.002%) compared to 2f5e5f7

View this Pull Request on Codecov

91.442% (-0.002%) compared to 2f5e5f7

Details

Codecov Report

Attention: Patch coverage is 67.50000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 91.442%. Comparing base (2f5e5f7) to head (5bc4277).

Files with missing lines Patch % Lines
Sources/SentrySwiftUI/SentryReplayView.swift 30.000% 7 Missing ⚠️
Sources/Swift/Tools/UIRedactBuilder.swift 75.000% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4392       +/-   ##
=============================================
- Coverage   91.443%   91.442%   -0.002%     
=============================================
  Files          629       629               
  Lines        50630     50656       +26     
  Branches     18344     18371       +27     
=============================================
+ Hits         46298     46321       +23     
- Misses        4238      4243        +5     
+ Partials        94        92        -2     
Files with missing lines Coverage Δ
Sources/Swift/Extensions/UIViewExtensions.swift 100.000% <ø> (ø)
Sources/Swift/Tools/SentryViewPhotographer.swift 92.000% <100.000%> (ø)
...entryTests/SwiftUI/SentryRedactModifierTests.swift 100.000% <100.000%> (ø)
Sources/Swift/Tools/UIRedactBuilder.swift 92.424% <75.000%> (-4.067%) ⬇️
Sources/SentrySwiftUI/SentryReplayView.swift 28.571% <30.000%> (+8.571%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f5e5f7...5bc4277. Read the comment docs.