-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: SwiftUI custom redact #4392
Open
brustolin
wants to merge
19
commits into
main
Choose a base branch
from
feat/SwiftUI-unmask
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+101
−28
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
627757d
ref: redact renamed to mask
brustolin ac59267
Update CHANGELOG.md
brustolin 68c872d
Update CHANGELOG.md
brustolin c082abc
Update SRRedactSampleViewController.swift
brustolin 8cbee68
Update UIRedactBuilderTests.swift
brustolin fb3c2a7
Update UIRedactBuilderTests.swift
brustolin 77ce313
Update SentryReplayView.swift
brustolin 77f3933
Wip
brustolin 122dba2
SwiftUI control
brustolin 3c32901
Merge branch 'main' into SwiftUI-unmask
brustolin a646e5c
Merge branch 'main' into feat/SwiftSR-Unmask
brustolin 18a130f
Merge branch 'feat/SwiftSR-Unmask' into SwiftUI-unmask
brustolin 4831454
wip
brustolin 6a3fee8
Update SentryRedactModifierTests.swift
brustolin 2cad7ef
expose SentryRedactViewHelper
brustolin 5a9010e
Update SentryReplayView.swift
brustolin 0b11da7
Update ContentView.swift
brustolin e29b384
Merge branch 'main' into feat/SwiftUI-unmask
brustolin 5bc4277
Update ContentView.swift
brustolin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m not super happy about making this class public, but SentrySwiftUI is an external module that needs access to it. Also, it’s impossible to misuse it in a way that would cause a crash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that you added some new methods. Maybe you can create an extra
SentryRedactViewHelper
just for SentrySwiftUI so you don't need to make it public?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not possible, I need to read it from RedactBuilder class that needs to be in the Sentry SDK.
Maybe if we split SR into a different module already we would need to worry less about this being public