-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(feedback): capture envelopes #4535
Open
armcknight
wants to merge
29
commits into
main
Choose a base branch
from
armcknight/feat(user-feedback)/envelope
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
armcknight
requested review from
philipphofmann and
brustolin
as code owners
November 15, 2024 00:51
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5e579af | 1239.16 ms | 1248.49 ms | 9.33 ms |
5e66a38 | 1209.10 ms | 1233.90 ms | 24.79 ms |
3277f18 | 1229.29 ms | 1248.92 ms | 19.63 ms |
3cba0e8 | 1250.86 ms | 1258.39 ms | 7.53 ms |
7fe37ab | 1228.92 ms | 1243.86 ms | 14.94 ms |
0ecf042 | 1228.25 ms | 1250.67 ms | 22.42 ms |
0970e44 | 1237.32 ms | 1251.53 ms | 14.21 ms |
e773cad | 1221.82 ms | 1240.55 ms | 18.73 ms |
f4a6925 | 1237.29 ms | 1249.35 ms | 12.07 ms |
216bdf9 | 1193.69 ms | 1217.90 ms | 24.21 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5e579af | 21.58 KiB | 656.60 KiB | 635.01 KiB |
5e66a38 | 22.85 KiB | 408.88 KiB | 386.03 KiB |
3277f18 | 22.84 KiB | 402.88 KiB | 380.03 KiB |
3cba0e8 | 22.84 KiB | 403.19 KiB | 380.34 KiB |
7fe37ab | 21.58 KiB | 542.28 KiB | 520.70 KiB |
0ecf042 | 21.58 KiB | 631.82 KiB | 610.24 KiB |
0970e44 | 22.32 KiB | 761.50 KiB | 739.18 KiB |
e773cad | 21.58 KiB | 681.75 KiB | 660.17 KiB |
f4a6925 | 21.58 KiB | 706.47 KiB | 684.89 KiB |
216bdf9 | 21.58 KiB | 418.13 KiB | 396.54 KiB |
Previous results on branch: armcknight/feat(user-feedback)/envelope
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
46f819e | 1216.73 ms | 1238.35 ms | 21.61 ms |
3c44525 | 1230.98 ms | 1250.49 ms | 19.51 ms |
3f71d28 | 1231.12 ms | 1253.88 ms | 22.76 ms |
c5dac22 | 1229.73 ms | 1252.24 ms | 22.51 ms |
6fbfc91 | 1237.08 ms | 1256.96 ms | 19.88 ms |
86abdac | 1209.79 ms | 1233.82 ms | 24.02 ms |
68416bc | 1227.29 ms | 1247.86 ms | 20.57 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
46f819e | 22.30 KiB | 759.88 KiB | 737.58 KiB |
3c44525 | 22.32 KiB | 765.14 KiB | 742.82 KiB |
3f71d28 | 22.30 KiB | 759.88 KiB | 737.58 KiB |
c5dac22 | 22.31 KiB | 760.57 KiB | 738.26 KiB |
6fbfc91 | 21.90 KiB | 746.34 KiB | 724.43 KiB |
86abdac | 21.90 KiB | 744.30 KiB | 722.40 KiB |
68416bc | 22.31 KiB | 760.79 KiB | 738.48 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is a draft, but I already gave you early feedback.
armcknight
changed the base branch from
main
to
armcknight/feat(user-feedback)/iteration
December 5, 2024 22:50
armcknight
force-pushed
the
armcknight/feat(user-feedback)/envelope
branch
from
December 5, 2024 22:52
6f2ddf0
to
5038ff5
Compare
armcknight
changed the title
feat(user-feedback): capture envelopes
feat(feedback): capture envelopes
Dec 5, 2024
Base automatically changed from
armcknight/feat(user-feedback)/iteration
to
main
December 7, 2024 02:53
armcknight
force-pushed
the
armcknight/feat(user-feedback)/envelope
branch
from
December 12, 2024 21:19
f84c1c7
to
2398c73
Compare
armcknight
changed the base branch from
main
to
armcknight/feat(feedback)/ui-form-use-user
December 12, 2024 21:19
armcknight
force-pushed
the
armcknight/feat(user-feedback)/envelope
branch
from
December 12, 2024 21:30
2398c73
to
e548832
Compare
armcknight
commented
Dec 13, 2024
armcknight
force-pushed
the
armcknight/feat(user-feedback)/envelope
branch
from
December 13, 2024 02:42
c4c1986
to
48c3f2b
Compare
…and showing up in the dashboard
armcknight
changed the base branch from
armcknight/feat(feedback)/ui-form-use-user
to
armcknight/feat(feedback)/api-visibility
December 13, 2024 02:48
armcknight
force-pushed
the
armcknight/feat(user-feedback)/envelope
branch
from
December 13, 2024 02:48
48c3f2b
to
4dcee7a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
armcknight
commented
Dec 13, 2024
Tests/SentryTests/Integrations/Feedback/SentryFeedbackTests.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments.
Tests/SentryTests/Integrations/Feedback/SentryFeedbackTests.swift
Outdated
Show resolved
Hide resolved
Tests/SentryTests/Integrations/Feedback/SentryFeedbackTests.swift
Outdated
Show resolved
Hide resolved
Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackForm.swift
Outdated
Show resolved
Hide resolved
Base automatically changed from
armcknight/feat(feedback)/api-visibility
to
main
December 14, 2024 00:23
…feedback)/envelope
armcknight
commented
Dec 20, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #4272; #skip-changelog
capture the user feedback in an envelope. currently, an error is required to have been captured, with its event ID supplied in the user feedback object. so, a dummy error is currently created to satisfy this requirement to be able to see them in the dashboard (see linked issue for progress/results)
TODOs