Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(feedback): validate envelopes #4652

Conversation

armcknight
Copy link
Member

@armcknight armcknight commented Dec 20, 2024

building off of #4535, tests for the new envelope we create for the feedback event; for #4272

#skip-changelog

@armcknight armcknight force-pushed the armcknight/feat(feedback)/validate-envelopes branch from 3170b09 to bc37550 Compare December 20, 2024 08:17
@armcknight armcknight force-pushed the armcknight/feat(feedback)/validate-envelopes branch from bc37550 to e79c9fa Compare December 20, 2024 09:12
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 38.63636% with 27 lines in your changes missing coverage. Please review.

Project coverage is 90.578%. Comparing base (1e4f7a3) to head (eeb4214).
Report is 1 commits behind head on armcknight/feat(user-feedback)/envelope.

Files with missing lines Patch % Lines
...ations/UserFeedback/SentryUserFeedbackWidget.swift 0.000% 9 Missing ⚠️
...Feedback/SentryUserFeedbackIntegrationDriver.swift 0.000% 6 Missing ⚠️
Sources/Sentry/SentryUserFeedbackIntegration.m 0.000% 5 Missing ⚠️
Sources/Sentry/SentryEnvelope.m 75.000% 4 Missing ⚠️
...grations/UserFeedback/SentryUserFeedbackForm.swift 0.000% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                              Coverage Diff                              @@
##           armcknight/feat(user-feedback)/envelope     #4652       +/-   ##
=============================================================================
- Coverage                                   90.601%   90.578%   -0.023%     
=============================================================================
  Files                                          623       623               
  Lines                                        71231     71218       -13     
  Branches                                     25985     25936       -49     
=============================================================================
- Hits                                         64536     64508       -28     
- Misses                                        6597      6613       +16     
+ Partials                                        98        97        -1     
Files with missing lines Coverage Δ
Sources/Sentry/SentryHttpTransport.m 98.127% <100.000%> (+0.028%) ⬆️
Sources/Sentry/SentryQueueableRequestManager.m 96.666% <ø> (-0.108%) ⬇️
...grations/UserFeedback/SentryUserFeedbackForm.swift 0.000% <0.000%> (ø)
Sources/Sentry/SentryEnvelope.m 89.320% <75.000%> (-1.305%) ⬇️
Sources/Sentry/SentryUserFeedbackIntegration.m 41.666% <0.000%> (-20.834%) ⬇️
...Feedback/SentryUserFeedbackIntegrationDriver.swift 0.000% <0.000%> (ø)
...ations/UserFeedback/SentryUserFeedbackWidget.swift 0.000% <0.000%> (ø)

... and 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e4f7a3...eeb4214. Read the comment docs.

Copy link

github-actions bot commented Dec 20, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1236.45 ms 1256.35 ms 19.91 ms
Size 22.32 KiB 766.03 KiB 743.71 KiB

Baseline results on branch: armcknight/feat(user-feedback)/envelope

Startup times

Revision Plain With Sentry Diff
46f819e 1216.73 ms 1238.35 ms 21.61 ms
3c44525 1230.98 ms 1250.49 ms 19.51 ms
3f71d28 1231.12 ms 1253.88 ms 22.76 ms
c5dac22 1229.73 ms 1252.24 ms 22.51 ms
6fbfc91 1237.08 ms 1256.96 ms 19.88 ms
86abdac 1209.79 ms 1233.82 ms 24.02 ms
68416bc 1227.29 ms 1247.86 ms 20.57 ms

App size

Revision Plain With Sentry Diff
46f819e 22.30 KiB 759.88 KiB 737.58 KiB
3c44525 22.32 KiB 765.14 KiB 742.82 KiB
3f71d28 22.30 KiB 759.88 KiB 737.58 KiB
c5dac22 22.31 KiB 760.57 KiB 738.26 KiB
6fbfc91 21.90 KiB 746.34 KiB 724.43 KiB
86abdac 21.90 KiB 744.30 KiB 722.40 KiB
68416bc 22.31 KiB 760.79 KiB 738.48 KiB

Previous results on branch: armcknight/feat(feedback)/validate-envelopes

Startup times

Revision Plain With Sentry Diff
7c33e26 1231.92 ms 1253.49 ms 21.57 ms

App size

Revision Plain With Sentry Diff
7c33e26 22.32 KiB 765.13 KiB 742.82 KiB

@armcknight

This comment was marked as resolved.

@armcknight armcknight merged commit ded938e into armcknight/feat(user-feedback)/envelope Dec 24, 2024
62 of 68 checks passed
@armcknight armcknight deleted the armcknight/feat(feedback)/validate-envelopes branch December 24, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant