-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(feedback): validate envelopes #4652
test(feedback): validate envelopes #4652
Conversation
3170b09
to
bc37550
Compare
bc37550
to
e79c9fa
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## armcknight/feat(user-feedback)/envelope #4652 +/- ##
=============================================================================
- Coverage 90.601% 90.578% -0.023%
=============================================================================
Files 623 623
Lines 71231 71218 -13
Branches 25985 25936 -49
=============================================================================
- Hits 64536 64508 -28
- Misses 6597 6613 +16
+ Partials 98 97 -1
... and 27 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
46f819e | 1216.73 ms | 1238.35 ms | 21.61 ms |
3c44525 | 1230.98 ms | 1250.49 ms | 19.51 ms |
3f71d28 | 1231.12 ms | 1253.88 ms | 22.76 ms |
c5dac22 | 1229.73 ms | 1252.24 ms | 22.51 ms |
6fbfc91 | 1237.08 ms | 1256.96 ms | 19.88 ms |
86abdac | 1209.79 ms | 1233.82 ms | 24.02 ms |
68416bc | 1227.29 ms | 1247.86 ms | 20.57 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
46f819e | 22.30 KiB | 759.88 KiB | 737.58 KiB |
3c44525 | 22.32 KiB | 765.14 KiB | 742.82 KiB |
3f71d28 | 22.30 KiB | 759.88 KiB | 737.58 KiB |
c5dac22 | 22.31 KiB | 760.57 KiB | 738.26 KiB |
6fbfc91 | 21.90 KiB | 746.34 KiB | 724.43 KiB |
86abdac | 21.90 KiB | 744.30 KiB | 722.40 KiB |
68416bc | 22.31 KiB | 760.79 KiB | 738.48 KiB |
This comment was marked as resolved.
This comment was marked as resolved.
ded938e
into
armcknight/feat(user-feedback)/envelope
building off of #4535, tests for the new envelope we create for the feedback event; for #4272
#skip-changelog