-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(flags): underscore featureflags module and identifier #3902
Conversation
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change and needs a major update for the SDK.
Is this something we MUST have or it is just a nice too have?
I would not want to make this breaking change only for cosmetic reasons.
@aliu39 and @cmanallen the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In our feature flag documentation we state that feature flag tracking is a beta feature.
Also FeatureFlagsIntegration
is not yet documented at all.
So renaming this is OK in a minor release.
@antonpirker The |
Follow-up to #3860, which hasn't been released yet