More consistent setters

[bdice]

Description

I made property setters look the same:

• Input parameter is named value.
• Property setting logic is always first (if value > 0:), error raising is always second (else: raise). This is my preference because it ensures the expected path is first (easier to read) and the condition matches the error message text (if value > 0 matches the error Value must be greater than zero. and is thus easier to think through).

I also added setters for ellipse area and ellipsoid volume. (I specifically needed ellipsoid volume but wanted ellipse area to match.)

Motivation and Context

Resolves #114. I did not know the issue already existed and had been assigned to @Tobias-Dwyer, I just wanted to add the volume setter for ellipsoids and figured I'd improve the code base at the same time.

Types of Changes

• Documentation update
• Bug fix
• New feature
• Breaking change¹

¹The change breaks (or has the potential to break) existing functionality.

Checklist:

• I am familiar with the Contributing Guidelines.
• I agree with the terms of the Contributor Agreement.
• The changes introduced by this pull request are covered by existing or newly introduced tests.
• I have updated the changelog and the credits.

[vyasr]

@Tobias-Dwyer this seems like a good PR for you to review :)

[Tobias-Dwyer]

All changes look Rolex to me :D . Thanks for adding the volume setters. Can you do the same thing for setting the surface area? just scale it? (if so I could probably go in and add it)

[bdice]

@Tobias-Dwyer Let’s open an issue and do surface areas / perimeters / etc. in a separate PR? I think the scope of this is complete as it is. (Fix all existing setters and add just the ones I needed immediately.)

[Tobias-Dwyer]

Yep, I agree :D

[bdice]

@Tobias-Dwyer Issue created: #125