INSTALL: Add libavahi and zlib as requirements #320
Conversation
| @@ -18,7 +18,9 @@ higher. | |||
| * libxml2 (RECOMMENDED) | |||
| * libcurl (RECOMMENDED) | |||
| * libdispatch (RECOMMENDED) | |||
| * libxslt (OPTIONAL) | |||
| * libavahi (RECOMMENDED for NSNetServices) | |||
| * libxslt (RECOMMENDED) | |||
There was a problem hiding this comment.
Why was this changed from OPTIONAL to RECOMMENDED?
There was a problem hiding this comment.
NSXMLDocument is using libxslt for methods like objectByApplyingXSLT:arguments:error: and returns nil if gnustep-base was compiled without libxslt (See https://github.com/gnustep/libs-base/blob/5f92c87d784753c996e14e4c75af7464014b6833/Source/NSXMLDocument.m#L429C8-L429C28).
Having an incomplete installation is just wrong imo.
OPTIONAL is used in a context where there are different options (i.e. gnutls and openssl, or iconv and glibc).
There was a problem hiding this comment.
I see, this is public API and available since macOS 10.4.
There was a problem hiding this comment.
I think we generally need to improve toolchain consistency by enforcing certain libraries during the configuration phase.
This is only a small patch that lifts libxslt, which is used in NSXMLDocument for xslt parsing, from OPTIONAL to RECOMMENDED, as a gnustep-base installation without libxslt would introduce inconsistency. The method objectByApplyingXSLT:arguments:error: (Available since Mac OS X 10.4) would just return nil if gnustep-base was compiled without libxslt support.
Additionally, libavahi for mDNS discovery, used in NSNetService (https://developer.apple.com/documentation/foundation/nsnetservice), and zlib, used in GSFileHandle for file compression should be listed and marked as RECOMMENDED.