Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INSTALL: Add libavahi and zlib as requirements #320

Merged
merged 1 commit into from
Sep 11, 2023
Merged

INSTALL: Add libavahi and zlib as requirements #320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion INSTALL
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ higher.
* libxml2 (RECOMMENDED)
* libcurl (RECOMMENDED)
* libdispatch (RECOMMENDED)
* libxslt (OPTIONAL)
* libavahi (RECOMMENDED for NSNetServices)
* libxslt (RECOMMENDED)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this changed from OPTIONAL to RECOMMENDED?

Copy link
Contributor Author

@hmelder hmelder Sep 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NSXMLDocument is using libxslt for methods like objectByApplyingXSLT:arguments:error: and returns nil if gnustep-base was compiled without libxslt (See https://github.com/gnustep/libs-base/blob/5f92c87d784753c996e14e4c75af7464014b6833/Source/NSXMLDocument.m#L429C8-L429C28).

Having an incomplete installation is just wrong imo.

OPTIONAL is used in a context where there are different options (i.e. gnutls and openssl, or iconv and glibc).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, this is public API and available since macOS 10.4.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we generally need to improve toolchain consistency by enforcing certain libraries during the configuration phase.

* zlib (RECOMMENDED)
* iconv (OPTIONAL, not needed if you have glibc)
* openssl (OPTIONAL, not needed if you have gnutls)

Expand Down
Loading