Set darwin's eglot config dir #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcs090218
approved these changes
Sep 21, 2023
|
Just to clarify - this is a separate problem, and I don't think it fixes the main bit of #137. Even with the correct port number, eglot disconnects. |
|
Thanks for your work. Do you not have merge permissions? Don't hesitate to merge your own PRs once they've been tested by a fellow contributor and approved. |
russmatney
added a commit
to russmatney/emacs-gdscript-mode
that referenced
this pull request
Jun 12, 2024
godotengine#138 was a good step, but the darwin and windows paths were not quite right when combined with the editor-settings path below - it was digging into an extra '/godot' directory and never finding the settings. This lifts that 'godot/' dir to only the linux system type. The docs for the paths are here: https://docs.godotengine.org/en/stable/tutorials/io/data_paths.html#editor-data-paths Eglot now starts automagically for me on osx! yay!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.