Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove extra /godot from osx/windows config path #151

Closed

Conversation

russmatney
Copy link

#138 was a good step, but the darwin and windows paths were not quite right when combined with the editor-settings path below - it was digging into an extra '/godot' directory and never finding the settings. This lifts that 'godot/' dir to only the linux system type.

The docs for the paths are here:
https://docs.godotengine.org/en/stable/tutorials/io/data_paths.html#editor-data-paths

Eglot now starts automagically for me on osx! yay!

godotengine#138 was a good
step, but the darwin and windows paths were not quite right when
combined with the editor-settings path below - it was digging into an
extra '/godot' directory and never finding the settings. This lifts that
'godot/' dir to only the linux system type.

The docs for the paths are here:
https://docs.godotengine.org/en/stable/tutorials/io/data_paths.html#editor-data-paths

Eglot now starts automagically for me on osx! yay!
@kkkykin
Copy link

kkkykin commented Aug 25, 2024

On windows, expand-file-name not handle "%APPDATA%" style env in right way, but substitute-in-file-name works. Here is example:

(let ((dir "%APPDATA%\\Godot\\")
      (fix (substitute-in-file-name "$APPDATA/Godot/")))
   (format "%s\n%s"
           (expand-file-name "editor_settings.tres" dir)
           (expand-file-name "editor_settings.tres" fix)))

The output is below, "c:/Users/k/scoop/persist/kshome/.emacs.d/elpa/gdscript-mode-20240509.1523/" is working directory.

c:/Users/k/scoop/persist/kshome/.emacs.d/elpa/gdscript-mode-20240509.1523/%APPDATA%/Godot/editor_settings.tres c:/Users/k/AppData/Roaming/Godot/editor_settings.tres

So change "%APPDATA%\\Godot\\" to (substitute-in-file-name "$APPDATA/Godot/") maybe correct.

-- Sorry for my poor english.

@russmatney
Copy link
Author

Not sure why this wasn't merged, but 🤷

Closing in favor of #156 which looks like a better (and more up-to-date) implementation.

@russmatney russmatney closed this Nov 3, 2024
@NathanLovato
Copy link
Collaborator

Sorry this didn't get merged before. This repository has a benevolent community maintainer who might not have been available to review and merge at the time. Generally, a lot of what you see in these FOSS organizations is benevolent, done in people's free time, as time allows, just like contributions.

@russmatney
Copy link
Author

Thanks for the reply! Sorry for the attitude in my comment 🤦‍♂️

I'm super appreciative of this tool and the community and individuals supporting it! Especially this rare cross-section of godot + emacs folks 🤓

image

@NathanLovato
Copy link
Collaborator

No worries, and thanks for the appreciation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants