Fix config directory in gdscript-eglot-contact #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've noticed there was #151, though it doesn't handle the case with |
katomuso
force-pushed
the
fix-config-dir
branch
from
e3cb436 to
e489295
Compare
|
This looks good! I wouldn't hold up merging this, but would at least mention this comment: #151 (comment) - might be a relevant detail for windows users in this code? |
jcs090218
approved these changes
Nov 3, 2024
katomuso
force-pushed
the
fix-config-dir
branch
from
e489295 to
d1076e1
Compare
|
@russmatney Thank you for pointing it out! Indeed, my solution required additional tweaks. |
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems there is a bug due to additionally concatenating the
godotdirectory to already proper config directories on macOS and Windows. According to https://docs.godotengine.org/en/latest/tutorials/io/data_paths.html#editor-data-paths, on macOS and Windows, editor settings are stored in theGodotdirectory. For example, currently on macOS the resulting directory path will be~/Library/Application Support/Godot/godot/when it should be~/Library/Application Support/Godot/.