Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add borders to BitMap in BitMapEditor #100761

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arkology
Copy link
Contributor

@arkology arkology commented Dec 23, 2024

Problem: try to guess where are borders of BitMap when using Black OLED theme:

I guess same problem might be if someone is using full white theme.


Solution: Draw outline around BitMap (TextureRect) - same way as #100569.

Preview for different themes:

Default theme Light Black OLED passivestar minimal theme
1_default 2_light 3_black_oled 4_passivestar_minimal

Note: There is a change in behavior of BitMapEditor. Previously TextureRect used STRETCH_KEEP_ASPECT_CENTERED so big textures tried to occupy all space they need:
Godot_v4 4-dev7_win64_WaS7sijHzS

Now BitMap texture will occupy up to 250 in height and proportional value in width.
image

For small-sized BitMap nothing has changed. Video below shows "after/before". "After" with outline around texture, "before" - without.

godot.windows.editor.dev.x86_64_xghhaWszCO.mp4

@arkology arkology marked this pull request as draft December 23, 2024 11:15
@Chaosus Chaosus added this to the 4.x milestone Dec 23, 2024
@arkology arkology force-pushed the bitmap-editor-outline branch from 88802e2 to 64af566 Compare December 24, 2024 14:07
@arkology arkology force-pushed the bitmap-editor-outline branch from 64af566 to b1d8530 Compare January 11, 2025 17:29
@arkology arkology marked this pull request as ready for review January 11, 2025 17:29
@arkology arkology force-pushed the bitmap-editor-outline branch from b1d8530 to 75cd784 Compare January 12, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants