Add borders to BitMap
in BitMapEditor
#100761
Open
+50
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: try to guess where are borders of
BitMap
when usingBlack OLED
theme:I guess same problem might be if someone is using full white theme.
Solution: Draw outline around
BitMap
(TextureRect
) - same way as #100569.Preview for different themes:
Note: There is a change in behavior of
BitMapEditor
. PreviouslyTextureRect
usedSTRETCH_KEEP_ASPECT_CENTERED
so big textures tried to occupy all space they need:Now
BitMap
texture will occupy up to 250 in height and proportional value in width.For small-sized
BitMap
nothing has changed. Video below shows "after/before". "After" with outline around texture, "before" - without.godot.windows.editor.dev.x86_64_xghhaWszCO.mp4