Make EditorSceneFormatImporter::_get_import_options match EditorScenePostImportPlugin API #100782
+46
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PostImportPlugin API
lyuma
force-pushed
the
add_import_option
branch
from
3f5a5cd to
23aad19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84516
After a lot of contemplating, I discovered that the EditorScenePostImportPlugin class had a similar API to the seemingly-broken
_get_import_optionsinEditorSceneFormatImporter. However, the difference is that reduz stored the options list in a local class member and addedadd_import_option(andadd_import_option_advanced) to allow registering import options inside of_get_import_options, so we do the same thing here.Also added some documentation mostly copied from the working APIs in
EditorScenePostImportPlugin, sinceEditorSceneFormatImporterwas missing a bunch of docs despite predating the post-import plugin system.