Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] [tvOS] tvOS Support #58977

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

naithar
Copy link
Contributor

@naithar naithar commented Mar 10, 2022

Same #58976 as for master

Rework of #45829 and #45830 PRs.
Implements proposal: godotengine/godot-proposals#224

tvOS and iOS platform uses new UIKit platform to share functionality and code.
UIKIT_ENABLED flag is used instead of IPHONE_ENABLED.

Export code is from previous PRs:

  • Launch screen is storyboard based (no need for launch images)
  • tvOS project supports empty Apple Team ID
  • Icons, Signatures and certificates are handled by Xcode project

Mono haven't been ported.
GDNative uses same configuration as iOS platform.
Support plugins that works the same way as iOS, but configuration is using .gdatvp

Related PRs: godotengine/build-containers#71, godotengine/godot-build-scripts#21 will be reworked for tvOS in future.

@@ -47,6 +47,15 @@ ClusterBuilderSharedDataRD::ClusterBuilderSharedDataRD() {
}

{
// FIXME: this block of code causes crash on tvOS
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how this should be approached - by skipping this shader compilation at all or using RenderingDevice::FramebufferFormatID

@aaronfranke
Copy link
Member

@naithar This PR need to be rebased before it can be considered, it has a lot of conflicts. The main problem is that the platform/iphone folder was renamed to platform/ios.

@Calinou
Copy link
Member

Calinou commented Oct 27, 2023

I would like to take this issue, and create a fresh new pull request or either this same in implementing work of @naithar to implement tvOS support in GODOT engine by milestone 4.x

Feel free to rebase this PR against master and test this again, but I expect this to be nontrivial. Given the size of this PR, this isn't something I would recommend for a new contributor unless you are highly familiar with iOS/tvOS development already.

@VSofficial
Copy link

Screenshot 2023-10-31 at 1 15 55 PM

@Calinou
Copy link
Member

Calinou commented Oct 31, 2023

@VSofficial Can you describe what you're referring to in detail?

@VSofficial
Copy link

That tvOS is not in the device family as it's not completed, although I haven't tested the build for tvOS as of now. Will test and if it fails will rectify it

@paulocoutinhox
Copy link

More than a year, why not it was merged? What left?

@AThousandShips
Copy link
Member

See this comment #58977 (comment), this hasn't been done so nothing can be done with this PR, the OP haven't fixed the necessary things, so it can't be reviewed and approved

@aaronfranke aaronfranke marked this pull request as draft December 19, 2023 17:14
@VSofficial
Copy link

More than a year, why not it was merged? What left?

I can't run the build on my device, I have taken the work to complete it and discussed the procedure with PR admin. I will complete necessary work and make a new PR

@tbrinton
Copy link

@VSofficial did you create a new PR? What is the status of it? I would love to bring some projects over to Godot but have been waiting for tvOS support. : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants