-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] [tvOS] tvOS Support #58977
base: master
Are you sure you want to change the base?
[4.0] [tvOS] tvOS Support #58977
Conversation
@@ -47,6 +47,15 @@ ClusterBuilderSharedDataRD::ClusterBuilderSharedDataRD() { | |||
} | |||
|
|||
{ | |||
// FIXME: this block of code causes crash on tvOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how this should be approached - by skipping this shader compilation at all or using RenderingDevice::FramebufferFormatID
8ff36e6
to
2d199ba
Compare
@naithar This PR need to be rebased before it can be considered, it has a lot of conflicts. The main problem is that the |
Feel free to rebase this PR against |
@VSofficial Can you describe what you're referring to in detail? |
That tvOS is not in the device family as it's not completed, although I haven't tested the build for tvOS as of now. Will test and if it fails will rectify it |
More than a year, why not it was merged? What left? |
See this comment #58977 (comment), this hasn't been done so nothing can be done with this PR, the OP haven't fixed the necessary things, so it can't be reviewed and approved |
I can't run the build on my device, I have taken the work to complete it and discussed the procedure with PR admin. I will complete necessary work and make a new PR |
@VSofficial did you create a new PR? What is the status of it? I would love to bring some projects over to Godot but have been waiting for tvOS support. : ) |
Same #58976 as for
master