Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] GDScript: Don't warn about RETURN_VALUE_DISCARDED by default #79077

Closed
wants to merge 0 commits into from

Conversation

SysError99
Copy link
Contributor

Following #69002. Turns out 4.x has a lot of changes in the GDScript module so cherry-picking it directly is out of question.

I can't really see the reason to keep it enabled by default even with 3.x especially when more of new features cherry-picked from 4.x introduce a lot of discarded values. Anyway, this left to be justified by the maintainer since warnings in 3.x aren't apparent in its own IDE but it's very annoying for users that use external editors.

@AThousandShips
Copy link
Member

Please use git rebase instead of merging into your branch, it make the git history very muddled and makes it harder to squash your commits

@AThousandShips
Copy link
Member

You accidentally re-signed all those commits instead of dropping them, you will need to remove all but your own contributions

@AThousandShips AThousandShips removed request for a team August 28, 2023 19:04
@SysError99
Copy link
Contributor Author

SysError99 commented Aug 28, 2023

Thanks, it's all my bad since my knowledge is still very limited. I'll redo everything now since this PR is pretty much broken.

@AThousandShips
Copy link
Member

Will probably be easiest, make sure to not create your PR from your 3.x branch but a dedicated PR branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants