Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Core: Add recursion level check for VariantWriter::write() #81114

Merged
merged 1 commit into from
Sep 6, 2023
Merged

[3.x] Core: Add recursion level check for VariantWriter::write() #81114

merged 1 commit into from
Sep 6, 2023

Conversation

dalexeev
Copy link
Member

Fixes a crash on the following code:

var a = []
a.append(a)
print(var2str(a))

See #79370 (comment).

@dalexeev dalexeev added bug topic:core crash cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels Aug 29, 2023
@dalexeev dalexeev added this to the 3.6 milestone Aug 29, 2023
@dalexeev dalexeev requested a review from a team as a code owner August 29, 2023 10:51
@dalexeev dalexeev force-pushed the 3.x-core-add-recursion-check-for-variant-writer branch from 8317e0f to 0213cbb Compare August 29, 2023 11:10
@dalexeev dalexeev mentioned this pull request Aug 29, 2023
Merged
@akien-mga akien-mga merged commit 2a6c7fc into godotengine:3.x Sep 6, 2023
13 checks passed
@akien-mga
Copy link
Member

Thanks!

@dalexeev dalexeev deleted the 3.x-core-add-recursion-check-for-variant-writer branch September 6, 2023 11:15
@akien-mga
Copy link
Member

Cherry-picked for 3.5.3.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug crash topic:core
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.
2 participants
@dalexeev @akien-mga