Add half precision floating point support to StreamPeer and FileAccess
#97716
+218
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RadiantUwU
reviewed
Oct 2, 2024
pafuent
force-pushed
the
add_half_precision_floating_point_to_stream_peer
branch
from
1f108d2
to
e00cbe8
Compare
RadiantUwU
approved these changes
Oct 2, 2024
pafuent
force-pushed
the
add_half_precision_floating_point_to_stream_peer
branch
2 times, most recently
from
1aea23d
to
19fd983
Compare
RadiantUwU
approved these changes
Oct 3, 2024
|
We should change the title and the topics since now it also modifies |
AThousandShips
changed the title
StreamPeerStreamPeer and FileAccess
pafuent
force-pushed
the
add_half_precision_floating_point_to_stream_peer
branch
from
19fd983
to
58fe877
Compare
|
Friendly remainder |
RadiantUwU
approved these changes
Oct 30, 2024
Calinou
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Tested locally, it works as expected.
Thanks for adding unit tests 🙂
extends Node2D
func _ready() -> void:
var fa := FileAccess.open("user://output.bin", FileAccess.WRITE_READ)
fa.store_half(0.123456)
fa.store_float(0.123456)
fa.store_double(0.123456)
fa.store_double(-12345)
fa.store_float(-12345)
fa.store_half(-12345)
OS.shell_open(ProjectSettings.globalize_path("user://"))
get_tree().quit()Using ImHex to view the file written by Godot:
Note the lack of precision on the second example, as half floats can't represent all integer values outside of [-2048; 2048].
AThousandShips
approved these changes
Nov 1, 2024
Closes godotengine/godot-proposals#5983 Adds put/get methods to `StreamPeer` that handles half precision floating point values. Adds endode/decode half precision floating point to `marshalls`. Adds `get_half` and `store_half` to `FileAccess` Co-Authored-By: "Alfonso J. Ramos" <[email protected]>
pafuent
force-pushed
the
add_half_precision_floating_point_to_stream_peer
branch
from
58fe877
to
189ee5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes godotengine/godot-proposals#5983
Adds put/get methods to
StreamPeerthat handles half precision floating point values.Adds endode/decode half precision floating point to
marshalls.This PR is rebase into master of #78872. Also I added unit tests to it.