Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RSA OAEP failure when given empty label with OpenSSL 3 #119

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

dagood
Copy link
Collaborator

@dagood dagood commented Sep 19, 2023

Found this while running x/crypto internal/wycheproof tests using the OpenSSL backend.

The doc is pretty clear that what we were doing should work:

EVP_PKEY_CTX_set0_rsa_oaep_label() sets the RSA OAEP label to binary data label and its length in bytes to len. If label is NULL or len is 0, the label is cleared.

Also fixes the error message to match the function name.

@dagood dagood changed the title Add RSAOAEP empty label test, failing on 3.0 Fix RSA OAEP failure when given empty label with OpenSSL 3 Sep 19, 2023
@dagood dagood marked this pull request as ready for review September 19, 2023 00:19
@qmuntal qmuntal merged commit 9783f40 into v2 Sep 19, 2023
16 checks passed
@qmuntal qmuntal deleted the dev/dagood/empty-label branch September 19, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants