Remove nox #1192
Merged
Remove nox #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removing nox from readme
remove nox from install.md
|
Thanks for taking this initiative in removing nox! Seems like there is an issue with python 3.8 which is quite old at this point and causing other problems too. We will be removing support for it at some point in the next month or two. Let's revisit this once it is removed. |
|
Ok, as of this commit: eb18a3b we've now removed Python 3.8 support. This will hopefully unblock this PR (among other things). Can you pull changes from master? |
lanctot
requested changes
Apr 5, 2024
lanctot
requested changes
Apr 5, 2024
There was a problem hiding this comment.
Also can you remove the reference to nox in the comment here:
Line 122 in eb18a3b
lanctot
requested changes
Apr 5, 2024
Closed
in build extension
# Conflicts: # .github/workflows/actions.yml
lanctot
approved these changes
Apr 8, 2024
lanctot
added
imported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.