Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nox #1192

Merged
merged 10 commits into from
Apr 8, 2024
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions docs/install.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,7 @@ issue.
Currently there are three installation methods:

1. building from the source code and editing `PYTHONPATH`.
2. using `pip install` to build and testing using
[nox](https://nox.thea.codes/en/stable/).
2. using `pip install`.
3. installing via [Docker](https://www.docker.com).

## Summary
Expand Down Expand Up @@ -132,14 +131,6 @@ In a nutshell:
./open_spiel/scripts/build_and_run_tests.sh
```

**Building and testing using PIP**

```bash
python3 -m pip install .
lanctot marked this conversation as resolved.
Show resolved Hide resolved
python3 -m pip install nox
nox -s tests
```

Optionally, use `pip install -e` to install in
[editable mode](https://pip.pypa.io/en/stable/reference/pip_install/#editable-installs),
which will allow you to skip this `pip install` step if you edit any Python
Expand Down
47 changes: 0 additions & 47 deletions noxfile.py

This file was deleted.

11 changes: 4 additions & 7 deletions open_spiel/scripts/build_and_run_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -181,14 +181,11 @@ function execute_export_graph {

# Build / install everything and run tests (C++, Python, optionally Julia).
if [[ $ARG_build_with_pip == "true" ]]; then
# TODO(author2): We probably want to use `python3 -m pip install .` directly
# and skip the usage of nox.
${PYBIN} -m pip install nox

if nox -s tests; then
echo -e "\033[32mAll tests passed. Nicely done!\e[0m"
${PYBIN} -m pip install .
if ctest -j$TEST_NUM_PROCS --output-on-failure ../open_spiel; then
print_tests_passed
else
echo -e "\033[31mAt least one test failed.\e[0m"
print_tests_failed
exit 1
fi
else
Expand Down
Loading