Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect lack of public annotations for colon-refs #1546

Conversation

cdleary
Copy link
Collaborator

@cdleary cdleary commented Aug 18, 2024

Adds an error test and fixes the resulting fallout in examples.

Note that synthetic proc init functions need to inherit their visibility from the proc they are defined inside.

Fixes #1507

@cdleary cdleary changed the title Respect lack of public annotations for colon-refs, fixes #1507 Respect lack of public annotations for colon-refs Aug 18, 2024
@cdleary
Copy link
Collaborator Author

cdleary commented Aug 18, 2024

Note the failures are unrelated to this change and reproduce at HEAD (without this PR) -- see #1547

copybara-service bot pushed a commit that referenced this pull request Aug 19, 2024
Precursor to #1546.

PiperOrigin-RevId: 664897978
@copybara-service copybara-service bot merged commit 11bd2dd into google:main Aug 19, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stdlib functions seem to bypass visibility check
2 participants