[DSLX:LS] Add support for prepareRename and rename #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdleary
force-pushed
the
cdleary/2024-09-26-lsp-prepare-rename
branch
from
bbe3eb5
to
424a5f1
Compare
cdleary
changed the title
|
Mind syncing & rerunning? Looks like CI failed... |
cdleary
force-pushed
the
cdleary/2024-09-26-lsp-prepare-rename
branch
2 times, most recently
from
bac0775
to
4c84049
Compare
Module-scoped renames for non-pub members.
cdleary
force-pushed
the
cdleary/2024-09-26-lsp-prepare-rename
branch
from
4c84049
to
acac707
Compare
Yeah, was really change related, had trouble seeing it since baseline was red. Setting parent link on module-top AST nodes was hazardous for some reason I don't fully understand so I made a simpler change. PTAL, thanks. |
richmckeever
approved these changes
Oct 3, 2024
grebe
requested changes
Oct 4, 2024
xls/dslx/lsp/find_definition.h
Outdated
| @@ -41,7 +41,8 @@ namespace xls::dslx { | |||
| // colon-reference to a construct in another module will return nullopt. | |||
| std::optional<Span> FindDefinition(const Module& m, const Pos& selected, | |||
| const TypeInfo& type_info, | |||
| ImportData& import_data); | |||
| ImportData& import_data, | |||
| const NameDef** name_def_out = nullptr); | |||
There was a problem hiding this comment.
Rather than returning name_def_out through an argument, it seems easier to have this be std::optional<NameDef*> FindDefinition(...) and have existing usages update to get the span from the NameDef.
What do you think? Is it really annoying to update the usages?
There was a problem hiding this comment.
Good idea, done, PTAL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works for intra-function and intra-module definitions.
Support is not present for cross-workspace renames yet.