chore: setup declarative configuration for branch protection and release-please #3091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lqiu96
reviewed
Aug 12, 2024
lqiu96
approved these changes
Aug 15, 2024
zhumin8
commented
Aug 26, 2024
.github/sync-repo-settings.yaml
Outdated
Comment on lines
73
to
79
| permissionRules: | ||
| - team: yoshi-admins | ||
| permission: admin | ||
| - team: yoshi-java-admins | ||
| permission: admin | ||
| - team: yoshi-java | ||
| permission: push |
There was a problem hiding this comment.
@blakeli0, this section is mimicked from google-cloud-java setups. Is permission rules with "yoshi-" teams still accurate? Do we prefer java specific teams as admin/push?
There was a problem hiding this comment.
Good point. We should probably start using the Java team sync group, @suztomo WDYT?
There was a problem hiding this comment.
Yes, the yoshi- teams are outdated.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3085
This change should migrate all required tests from "settings" tab to
.github/sync-repo-settings.yaml. Also setting up release-please branches for lts.Sync-repo-settings.yaml is updated referencing this guide, and settings in google-cloud-java here.
Release-please.yaml is updated referencing this and google-cloud-java settings here.
Questions to reviewers: