Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: setup declarative configuration for branch protection and release-please #3091

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

chore: setup declarative configuration for branch protection and release-please #3091

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e72b5bc
chore: add lts branches to release-please.yml
zhumin8 Aug 6, 2024
12667c5
chore: setup branch protection rules.
zhumin8 Aug 6, 2024
707f2c6
Merge branch 'main' into setup-protection
zhumin8 Aug 8, 2024
dae05e2
review feedback: add buid/showcase 21 and showcase-native as required…
zhumin8 Aug 13, 2024
d1978f6
update permission.
zhumin8 Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,12 @@ handleGHRelease: true
primaryBranch: main
manifest: true
extraFiles: ["WORKSPACE", ".cloudbuild/graalvm/cloudbuild.yaml", ".cloudbuild/graalvm/cloudbuild-test-a.yaml", ".cloudbuild/graalvm/cloudbuild-test-b.yaml", ".cloudbuild/library_generation/cloudbuild-library-generation-release.yaml", "generation_config.yaml"]
branches:
- branch: 2.23.x
releaseType: java-backport
manifest: true
handleGHRelease: true
- branch: 2.40.x
releaseType: java-backport
manifest: true
handleGHRelease: true
71 changes: 71 additions & 0 deletions .github/sync-repo-settings.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,74 @@
rebaseMergeAllowed: true
squashMergeAllowed: true
mergeCommitAllowed: false
branchProtectionRules:
- pattern: main
isAdminEnforced: true
requiredApprovingReviewCount: 1
requiresCodeOwnerReviews: true
requiresStrictStatusChecks: false
requiredStatusCheckContexts:
- build (8) except for gapic-generator-java
- build (8) for gapic-generator-java
- build (11)
- build (17)
- showcase (11)
- showcase (17)
zhumin8 marked this conversation as resolved.
Show resolved Hide resolved
- compatibility
- cla/google
- lint
- graalvm-presubmit-sdk-platform-java-a (cloud-devrel-kokoro-resources)
- graalvm-presubmit-sdk-platform-java-b (cloud-devrel-kokoro-resources)
- library-generation-integration-tests
- library-generation-lint-shell
- library-generation-lint-python
- should-run-library-generation-tests
- pattern: 2.23.x
isAdminEnforced: true
requiredApprovingReviewCount: 1
requiresCodeOwnerReviews: true
requiresStrictStatusChecks: false
requiredStatusCheckContexts:
- build (8) except for gapic-generator-java
- build (8) for gapic-generator-java
- build (11)
- build (17)
- showcase (11)
- showcase (17)
- compatibility
- cla/google
- lint
- graalvm-presubmit-sdk-platform-java-a (cloud-devrel-kokoro-resources)
- graalvm-presubmit-sdk-platform-java-b (cloud-devrel-kokoro-resources)
- library-generation-integration-tests
- library-generation-lint-shell
- library-generation-lint-python
- should-run-library-generation-tests
- pattern: 2.40.x
isAdminEnforced: true
requiredApprovingReviewCount: 1
requiresCodeOwnerReviews: true
requiresStrictStatusChecks: false
requiredStatusCheckContexts:
- build (8) except for gapic-generator-java
- build (8) for gapic-generator-java
- build (11)
- build (17)
- showcase (11)
- showcase (17)
- compatibility
- cla/google
- lint
- graalvm-presubmit-sdk-platform-java-a (cloud-devrel-kokoro-resources)
- graalvm-presubmit-sdk-platform-java-b (cloud-devrel-kokoro-resources)
- library-generation-integration-tests
- library-generation-lint-shell
- library-generation-lint-python
- should-run-library-generation-tests
permissionRules:
- team: yoshi-admins
permission: admin
- team: yoshi-java-admins
permission: admin
- team: yoshi-java
permission: push
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blakeli0, this section is mimicked from google-cloud-java setups. Is permission rules with "yoshi-" teams still accurate? Do we prefer java specific teams as admin/push?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. We should probably start using the Java team sync group, @suztomo WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the yoshi- teams are outdated.

Loading