mimir-build-image: Upgrade Go version to 1.23.0-bookworm #9070

alexweav · 2024-08-21T20:44:43Z

What this PR does

Upgrades Go version in mimir-build-image.

This required an upgrade to golangci-lint. In turn, the upgrade of this introduced a new linter rule for constant format strings (which in rare cases can be a security thing). Fixed all violations of this new linter rule.

Which issue(s) this PR fixes or relates to

n/a

Checklist

Tests updated.
Documentation added.
CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
about-versioning.md updated with experimental features.

github-actions · 2024-08-21T20:45:26Z

Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version grafana/mimir-build-image:pr9070-2850516d73. This can take up to 1 hour.

alexweav · 2024-08-21T20:45:32Z

Not ready to merge yet: Awaiting image to be built and bot commit per instructions https://github.com/grafana/mimir/blob/main/docs/internal/how-to-update-the-build-image.md?plain=1

github-actions · 2024-08-21T22:53:40Z

Not building new version of mimir-build-image. This PR modifies mimir-build-image/Dockerfile, but the image grafana/mimir-build-image:pr9070-2850516d73 already exists.

aknuds1

I think you have to upgrade to the latest version of golangci-lint also. That's probably why the lint CI job failed.

github-actions · 2024-08-22T20:30:32Z

Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version grafana/mimir-build-image:pr9070-3b4c4993ed. This can take up to 1 hour.

github-actions · 2024-08-22T21:55:21Z

Not building new version of mimir-build-image. This PR modifies mimir-build-image/Dockerfile, but the image grafana/mimir-build-image:pr9070-3b4c4993ed already exists.

alexweav · 2024-08-22T22:01:51Z

Thanks @aknuds1 😄

The remaining lint errors seem to be new/legitimate ones caught by the upgraded linter - i'll post another commit fixing these up tomorrow.

github-actions · 2024-08-23T15:15:54Z

Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version grafana/mimir-build-image:pr9070-5347ec889b. This can take up to 1 hour.

github-actions · 2024-08-23T15:25:13Z

Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version grafana/mimir-build-image:pr9070-5347ec889b. This can take up to 1 hour.

github-actions · 2024-08-23T15:35:38Z

Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version grafana/mimir-build-image:pr9070-5347ec889b. This can take up to 1 hour.

aknuds1

Please see suggestions for cleanup.

pkg/distributor/distributor_ingest_storage_test.go

pkg/distributor/otel.go

pkg/distributor/push.go

pkg/distributor/push_test.go

pkg/scheduler/scheduler.go

tools/tsdb-index-toc/main.go

github-actions · 2024-08-23T15:44:25Z

Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version grafana/mimir-build-image:pr9070-5347ec889b. This can take up to 1 hour.

Co-authored-by: Arve Knudsen <[email protected]>

github-actions · 2024-08-23T15:46:04Z

Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version grafana/mimir-build-image:pr9070-5347ec889b. This can take up to 1 hour.

github-actions · 2024-08-23T15:49:10Z

Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version grafana/mimir-build-image:pr9070-5347ec889b. This can take up to 1 hour.

github-actions · 2024-08-23T15:52:18Z

Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version grafana/mimir-build-image:pr9070-5347ec889b. This can take up to 1 hour.

aknuds1

Left a nit, I think linting will still fail for a couple of cases.

aknuds1

Sorry, my suggestion got lost in the previous review.

pkg/scheduler/scheduler.go

Co-authored-by: Arve Knudsen <[email protected]>

alexweav · 2024-08-23T16:00:59Z

Indeed, I do wish the linter would report all the errors at once on the CI rather than reporting them in batches.

aknuds1 · 2024-08-23T16:01:43Z

Indeed, I do wish the linter would report all the errors at once on the CI rather than reporting them in batches.

It's the easiest to lint locally.

github-actions · 2024-08-23T16:02:02Z

Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version grafana/mimir-build-image:pr9070-5347ec889b. This can take up to 1 hour.

alexweav · 2024-08-23T16:03:47Z

Yeah, having to fall back to that it seems. I was misled by the last round (having only one error reported) into thinking I am done 🙈

github-actions · 2024-08-23T16:11:36Z

Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version grafana/mimir-build-image:pr9070-5347ec889b. This can take up to 1 hour.

aknuds1

LGTM, thanks!

alexweav · 2024-08-23T16:15:07Z

Thanks for the review @aknuds1!

Signed-off-by: Arve Knudsen <[email protected]>

github-actions · 2024-08-23T17:00:44Z

Not building new version of mimir-build-image. This PR modifies mimir-build-image/Dockerfile, but the image grafana/mimir-build-image:pr9070-5347ec889b already exists.

alexweav requested a review from a team as a code owner August 21, 2024 20:44

github-actions bot requested review from wilfriedroset, vaxvms and bubu11e as code owners August 21, 2024 21:20

aknuds1 reviewed Aug 22, 2024

View reviewed changes

alexweav and others added 7 commits August 23, 2024 10:13

Upgrade to 1.23.0-bookworm

70aafeb

Update build image version to pr9070-2850516d73

dd4eb4e

empty commit to kick drone

a9bf892

Upgrade golangci-lint

4e2d41c

Update build image version to pr9070-3b4c4993ed

d1556f9

empty commit, drone disconnected again

73ddc11

Address various linter complaints following upgrade

cc76be0

alexweav force-pushed the alexweav/upgrade-build-image-go-1-23-0 branch from e9ef469 to cc76be0 Compare August 23, 2024 15:15

More lint errors

16a3425

reports lint errors in batches apparently, more

a52826a

aknuds1 requested changes Aug 23, 2024

View reviewed changes

One additional fix, a portion of PR feedback

ec3e36f

Apply suggestions from code review

316d710

Co-authored-by: Arve Knudsen <[email protected]>

Manually apply a few more following logic from comments

7438520

Reverse cancellation.NewError one

35c113b

aknuds1 reviewed Aug 23, 2024

View reviewed changes

pkg/scheduler/scheduler.go Outdated Show resolved Hide resolved

Update pkg/scheduler/scheduler.go

936611f

Co-authored-by: Arve Knudsen <[email protected]>

last round, hopefully

38d46d9

aknuds1 approved these changes Aug 23, 2024

View reviewed changes

Update build image version to pr9070-5347ec889b

4bed73e

Signed-off-by: Arve Knudsen <[email protected]>

aknuds1 force-pushed the alexweav/upgrade-build-image-go-1-23-0 branch from 86c300f to 4bed73e Compare August 23, 2024 17:00

aknuds1 enabled auto-merge (squash) August 23, 2024 17:01

aknuds1 merged commit 87f601f into main Aug 23, 2024
30 checks passed

aknuds1 deleted the alexweav/upgrade-build-image-go-1-23-0 branch August 23, 2024 17:17

narqo mentioned this pull request Sep 3, 2024

Support go 1.23 #9033

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mimir-build-image: Upgrade Go version to 1.23.0-bookworm #9070

mimir-build-image: Upgrade Go version to 1.23.0-bookworm #9070

alexweav commented Aug 21, 2024 •

edited

Loading

github-actions bot commented Aug 21, 2024

alexweav commented Aug 21, 2024

github-actions bot commented Aug 21, 2024

aknuds1 left a comment

github-actions bot commented Aug 22, 2024

github-actions bot commented Aug 22, 2024

alexweav commented Aug 22, 2024

github-actions bot commented Aug 23, 2024

github-actions bot commented Aug 23, 2024

github-actions bot commented Aug 23, 2024

aknuds1 left a comment

github-actions bot commented Aug 23, 2024

github-actions bot commented Aug 23, 2024

github-actions bot commented Aug 23, 2024

github-actions bot commented Aug 23, 2024

aknuds1 left a comment

aknuds1 left a comment

alexweav commented Aug 23, 2024

aknuds1 commented Aug 23, 2024

github-actions bot commented Aug 23, 2024

alexweav commented Aug 23, 2024

github-actions bot commented Aug 23, 2024

aknuds1 left a comment

alexweav commented Aug 23, 2024

github-actions bot commented Aug 23, 2024

mimir-build-image: Upgrade Go version to 1.23.0-bookworm #9070

mimir-build-image: Upgrade Go version to 1.23.0-bookworm #9070

Conversation

alexweav commented Aug 21, 2024 • edited Loading

What this PR does

Which issue(s) this PR fixes or relates to

Checklist

github-actions bot commented Aug 21, 2024

alexweav commented Aug 21, 2024

github-actions bot commented Aug 21, 2024

aknuds1 left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 22, 2024

github-actions bot commented Aug 22, 2024

alexweav commented Aug 22, 2024

github-actions bot commented Aug 23, 2024

github-actions bot commented Aug 23, 2024

github-actions bot commented Aug 23, 2024

aknuds1 left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 23, 2024

github-actions bot commented Aug 23, 2024

github-actions bot commented Aug 23, 2024

github-actions bot commented Aug 23, 2024

aknuds1 left a comment

Choose a reason for hiding this comment

aknuds1 left a comment

Choose a reason for hiding this comment

alexweav commented Aug 23, 2024

aknuds1 commented Aug 23, 2024

github-actions bot commented Aug 23, 2024

alexweav commented Aug 23, 2024

github-actions bot commented Aug 23, 2024

aknuds1 left a comment

Choose a reason for hiding this comment

alexweav commented Aug 23, 2024

github-actions bot commented Aug 23, 2024

alexweav commented Aug 21, 2024 •

edited

Loading