Fix 1204: panic while exporting nil sobek values #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exports the Goja values if they're not nil. For the arrays, exportArgs leave the nil values within the array. This is because users want to pass nil values to their functions (i.e., Evaluate).
This is for testing the mapping layer's behavior when evaluate is called without an array.
inancgumus
force-pushed
the
fix/1204-fix-panic-while-exporting-nil-goja-values
branch
from
67133a3
to
b7da453
Compare
This increases clarity for finding helpers.
inancgumus
deleted the
fix/1204-fix-panic-while-exporting-nil-goja-values
branch
inancgumus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
nullvalues to methods.Checklist
Related PR(s)/Issue(s)
Updates: #1204