Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 1204: panic while exporting nil sobek values #1205

Merged
merged 6 commits into from
Feb 6, 2024
Merged

Fix 1204: panic while exporting nil sobek values #1205

merged 6 commits into from
Feb 6, 2024

Commits on Feb 2, 2024

  1. Fix panic while exporting a nil Goja value 

    Exports the Goja values if they're not nil. For the arrays, exportArgs
leave the nil values within the array. This is because users want to
pass nil values to their functions (i.e., Evaluate).
    @inancgumus
    inancgumus committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    153b3fc View commit details
    Browse the repository at this point in the history

  2. Update the evaluate example with a null param 

    This is for testing the mapping layer's behavior when evaluate is called
without an array.
    @inancgumus
    inancgumus committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    9bb0d08 View commit details
    Browse the repository at this point in the history

  3. Add a dispatch event example

    @inancgumus
    inancgumus committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    b7da453 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Move gojaValueExists to the mapping layer

    @inancgumus
    inancgumus committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    43be12c View commit details
    Browse the repository at this point in the history

  2. Move mapping helpers to a file 

    This increases clarity for finding helpers.
    @inancgumus
    inancgumus committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    f5f26e9 View commit details
    Browse the repository at this point in the history

  3. Use gojaValueExists in exportArg

    @inancgumus
    inancgumus committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    36a214e View commit details
    Browse the repository at this point in the history