javax to jakarta, groovy 4, spring framework 6 and spring boot 3 migrations #1810

jamesfredley · 2024-08-22T16:25:10Z

PR so that a 9.0.0-SNAPSHOT can be published and we can continue working on other grails dependencies while we work on the failing tests ignored on this PR. #1811

Key Changes and issues:

Groovy-5106 issues:

The interface GormEntity cannot be implemented more than once with different arguments: org.grails.datastore.gorm.GormEntity<grails.gorm.tests.XXX> and org.grails.datastore.gorm.GormEntity<grails.gorm.tests.XXX>
https://github.com/grails/grails-data-mapping/pull/1810/files#diff-27ed87cb0bd085350a84cfb91c31242c7d3d516c64915076f927f2c746b25697
https://github.com/grails/grails-data-mapping/pull/1810/files#diff-e67a9d7f3d3f5d5c003fa33e3c6f4b8d65ecb714712905e92422fec02e4b2ccf
https://github.com/grails/grails-data-mapping/pull/1810/files#diff-4b36d1f95600c55e2dd8bfad1da2563ada49f20f037d441b40fc6639eee6c604
https://github.com/grails/grails-data-mapping/pull/1810/files#diff-9117157b9f4726fc00e80fbe03952dd5a9cdd9bf41ce93b9542fe38f7430309c
https://github.com/grails/grails-data-mapping/pull/1810/files#diff-eb7836a49960ae16314b800bd5db04b4d97950a933ceb9910f48707ea4b5ad12
https://github.com/grails/grails-data-mapping/pull/1810/files#diff-f7129bc6cdd92838d45ac5d0b544dce61291ab65cdb1fbcedaa9be74b9b05fad

Tenants changes -

error: name clash: currentId(Class<? extends RxDatastoreClient>) in grails.gorm.rx.multitenancy.Tenants and currentId(Class<? extends Datastore>) in grails.gorm.multitenancy.Tenants have the same erasure, yet neither hides the other
public static  java.io.Serializable currentId(java.lang.Class<? extends org.grails.datastore.rx.RxDatastoreClient> datastoreClass) { return (java.io.Serializable)null;}

Tenants.java:11: error: name clash: <T#1>withCurrent(Class<? extends RxDatastoreClient>,Closure<T#1>) in grails.gorm.rx.multitenancy.Tenants and <T#2>withCurrent(Class<? extends Datastore>,Closure<T#2>) in grails.gorm.multitenancy.Tenants have the same erasure, yet neither hides the other
public static <T> T withCurrent(java.lang.Class<? extends org.grails.datastore.rx.RxDatastoreClient> datastoreClass, @groovy.lang.DelegatesTo(value=org.grails.datastore.rx.RxDatastoreClient.class) groovy.lang.Closure<T> callable) { return (T)null;}
                    ^
  where T#1,T#2 are type-variables:
    T#1 extends Object declared in method <T#1>withCurrent(Class<? extends RxDatastoreClient>,Closure<T#1>)
    T#2 extends Object declared in method <T#2>withCurrent(Class<? extends Datastore>,Closure<T#2>)

https://github.com/grails/grails-data-mapping/pull/1810/files#diff-7708c0f3847869b8ff4971104b44c9747b78707413ab99da13e34981f7e21691

Annotation Metadata Reader

https://github.com/grails/grails-data-mapping/pull/1810/files#diff-c766af43d516aa0d817579bbd8ec67e3fca6d2ef567f172b415fe88f7901650e

javax in Grails Package hierarchy and class name

https://github.com/grails/grails-data-mapping/pull/1810/files#diff-32943b7b556a0f60770ec10dada5053c28e619dc6d88b955decc7e018d69db70
renamed package and class

CastExpression.asExpression(newReturnType, returnExpr)

https://github.com/grails/grails-data-mapping/pull/1810/files#diff-298a9c9326beaac1ddf877eb26c396572831812cf35d52667e1cf8e480b76297

The interface XXX cannot be implemented more than once with different arguments: java.util.Example<java.lang.Object> and java.util.Example<E>

https://github.com/grails/grails-data-mapping/pull/1810/files#diff-e77ee4b62b7ff830feddde3a0c6d2c3b073927f75e70a1b0d43c527136c76d80
https://github.com/grails/grails-data-mapping/pull/1810/files#diff-01a7e593dc1261f2ab713f5e740bdcf8b222d2f4ec935fa70f8bb97f45aace68
https://github.com/grails/grails-data-mapping/pull/1810/files#diff-fa2aeeaeb7a85f0991bf9319dc119a425a32597fa99ac61a374452863416dcf1
The changes to extends and implements on RxPersistentSortedSet.groovy resolved the above rather generic error: org.codehaus.groovy.syntax.RuntimeParserException: The interface Set cannot be implemented more than once with different arguments: java.util.Set<java.lang.Object> and java.util.Set<E>
https://github.com/grails/grails-data-mapping/pull/1810/files#diff-0717c9ff3dac125db0a958e2f0ae1b845bf6e703957e29148b2aaedcc36e8fc0
https://github.com/grails/grails-data-mapping/pull/1810/files#diff-d3b653109b246c87c34c3e2ab9aefa6d716b2d9297d9048ec81108da291911ee
https://github.com/grails/grails-data-mapping/pull/1810/files#diff-d7496229b30eb8468fc3bb6f3805ad6e3233a8a74e1150723255ea2682fe113a
https://github.com/grails/grails-data-mapping/pull/1810/files#diff-14b92adaede32ac0daf85e12325a785aa7738c662ac47967fdb1f0ec1b061bb8

More test failures:

https://github.com/grails/grails-data-mapping/pull/1810/files#diff-50a99d77e04ca2ce8390a54c4b292ecd43315ce23a39cba456d20b2438f0e0e5
Cannot implement method for argument [title], No implementations possible for method 'rx.Observable updateBook(java.lang.String, java.lang.String)
https://github.com/grails/grails-data-mapping/pull/1810/files#diff-91b8d65fd4ce06aba9ae88d79069c79c84cccd1bf920d78579fb79ec4058792f
java.lang.IllegalStateException: Either class [grails.gorm.services.multitenancy.partitioned.Book] is not a domain class or GORM has not been initialized correctly or has already been shutdown. Ensure GORM is loaded and configured correctly before calling any methods on a GORM entity.
https://github.com/grails/grails-data-mapping/pull/1810/files#diff-5308fcc21bbd00b74eb7fe0fb1b844293ea4be3c3e22be1b0f1858ece8144a85
java.lang.IllegalStateException: Either class [grails.gorm.services.multitenancy.schema.Book] is not a domain class or GORM has not been initialized correctly or has already been shutdown. Ensure GORM is loaded and configured correctly before calling any methods on a GORM entity.
-https://github.com/grails/grails-data-mapping/pull/1810/files#diff-db6628bfbaa9316ae15a143760a4e8f08ab13d7b3b9768f1889f87c4c2303d18
java.lang.StackOverflowError