Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default service_name for GriptapeCloudObservabilityDriver #988

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

dylanholmes
Copy link
Contributor

@dylanholmes dylanholmes commented Jul 16, 2024

Changes:

  • Set a default open telemetry service name in GriptapeCloudObservabilityDriver as it is not meaningful within in Griptape cloud.
  • Fixing ruff changes after rebase

Merging into release/cloud-unreleased


📚 Documentation preview 📚: https://griptape--988.org.readthedocs.build//988/

@dylanholmes dylanholmes force-pushed the fix/remove-service-name branch from bf70df8 to 9b33397 Compare July 16, 2024 21:58
@dylanholmes dylanholmes force-pushed the fix/remove-service-name branch from 9b33397 to 5d40199 Compare July 16, 2024 21:58
@dylanholmes dylanholmes marked this pull request as ready for review July 16, 2024 21:58
@dylanholmes dylanholmes requested a review from collindutter July 16, 2024 21:59
@dylanholmes dylanholmes merged commit 8ebb262 into release/cloud-unreleased Jul 16, 2024
2 checks passed
@dylanholmes dylanholmes deleted the fix/remove-service-name branch July 16, 2024 22:03
@dylanholmes dylanholmes mentioned this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants