Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xds fallback #11254
base: master
Are you sure you want to change the base?
Xds fallback #11254
Changes from 8 commits
25aa454
d8f7094
d0e7ba2
c2f0ecc
2ab47a5
38267d5
05d188f
dedb8fe
22b5a0c
003348b
2c11225
7323f25
fe384a8
4d2e4d8
23b6740
b5d69d3
5b28d7a
1169f39
8d22cfd
023c6cd
517bcc3
230c18d
7975051
5c6b524
b979d70
5a2e071
5df91a4
34a7b83
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we stop with this pattern? Some rare cases could be fine, but let's not do it regularly. Let's instead go with the pattern:
And in tests modify that variable instead of the system property. The same approach as done in bootstrapper.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: delete. Probably left over from now-reverted changes.
Check warning on line 116 in xds/src/main/java/io/grpc/xds/client/BootstrapperImpl.java
Codecov / codecov/patch
xds/src/main/java/io/grpc/xds/client/BootstrapperImpl.java#L116
Check warning on line 225 in xds/src/main/java/io/grpc/xds/client/BootstrapperImpl.java
Codecov / codecov/patch
xds/src/main/java/io/grpc/xds/client/BootstrapperImpl.java#L225