Revert "Specify link attribute for Windows to be happy"

[thiblahute]

This reverts commit a8dc213.

Linking flags should be provided by the system-deps crate. Specifying linking with the attribute creates issue when statically linking system dependencies.

[sdroege]

This will likely break things on Windows CC @seungha-yang.

Also after this it will be required to change some manual cases, e.g. in glib/src/param_spec.rs

[sdroege]

Unfortunately none of us can remember the details of this and the PR description was not very... descriptive.

Can you try removing all these, and then try building

1. gst-plugins-rs in MSVC
2. Some Rust application using the bindings in MSVC

If that all works fine it's probably all OK.

[thiblahute]

I update gst-rs with that commit and CI passes: https://gitlab.freedesktop.org/thiblahute/gstreamer-rs/-/pipelines/904700 (well apart from regen-check) .

I updated gst-plugins-rs on top of that and ci looks all good https://gitlab.freedesktop.org/thiblahute/gst-plugins-rs/-/pipelines/904754

Do you think that is enough?

[sdroege]

Please compile gst-plugins-rs with gtk-rs-core, gtk4 and gstreamer-rs regenerated with this and the manual #[link] attributes removed from the code too. That would be enough to convince me that this is not needed anymore :)

[sdroege]

@thiblahute Any updates here?

[sdroege]

gtk-rs/gtk-rs-core@d14883c has some more background why this was added, and also gtk-rs/gtk-rs-core#1199 is related.

[sdroege]

Can be closed now: #1600