Remove explicit linking in param_spec.rs #1199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was specifically added for MSVC on Windows, see d14883c |
|
The actual fix would be finishing gtk-rs/gir#1298 |
|
gtk-rs/gir#1475 is also kind of related here |
|
Let us close this one as it is not the correct solution as mentioned above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the issue in librsvg here: https://gitlab.gnome.org/GNOME/librsvg/-/issues/896
I think this line can be removed, which fixes the ability to statically link the stack on e.g. Windows.