Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more manual stuff #213

Merged
merged 22 commits into from
Mar 22, 2021
Merged

more manual stuff #213

merged 22 commits into from
Mar 22, 2021

Conversation

bilelmoussaoui
Copy link
Member

No description provided.

@bilelmoussaoui bilelmoussaoui force-pushed the bilelmoussaoui/gtk-more-manual-3 branch 11 times, most recently from c32f3a9 to ceab392 Compare March 11, 2021 10:57
@bilelmoussaoui bilelmoussaoui force-pushed the bilelmoussaoui/gtk-more-manual-3 branch from ceab392 to ddf2dce Compare March 11, 2021 11:30
sdroege
sdroege reviewed Mar 11, 2021
View reviewed changes
gtk4/Gir.toml Show resolved Hide resolved
sdroege
sdroege reviewed Mar 11, 2021
View reviewed changes
gtk4/src/editable.rs Outdated Show resolved Hide resolved
sdroege
sdroege reviewed Mar 11, 2021
View reviewed changes
gtk4/src/media_stream.rs Outdated Show resolved Hide resolved
@bilelmoussaoui bilelmoussaoui force-pushed the bilelmoussaoui/gtk-more-manual-3 branch from ddf2dce to adafca2 Compare March 16, 2021 18:07
@bilelmoussaoui
gtk: manually implement TreeRowReference::reordered
8308184
@bilelmoussaoui
gtk: manually implement Editable::install_properties
8b22dca 
The method is expected to be called in class_init, so handle it as EditableClassSubclassExt auto implemented trait
@bilelmoussaoui
gtk: fix Editable::(get|set)_delegate_property signatures
086bfc2
@bilelmoussaoui
gtk: manually implement MessageDialog markup methods
f802cc0 
From Rust you should rather call format! then pass the formatted string
instead of using a weird C api.
@bilelmoussaoui
gtk: manually implement TreeModelFilter::set_modify_func
c54cf5a
@bilelmoussaoui bilelmoussaoui force-pushed the bilelmoussaoui/gtk-more-manual-3 branch 5 times, most recently from c919327 to 96fcdfa Compare March 21, 2021 20:12
@bilelmoussaoui
Copy link
Member Author

Ok, i'm happy with the status of this merge request

sdroege
sdroege reviewed Mar 22, 2021
View reviewed changes
gtk4/src/cell_area.rs Outdated Show resolved Hide resolved
sdroege
sdroege reviewed Mar 22, 2021
View reviewed changes
gtk4/src/media_stream.rs Outdated Show resolved Hide resolved
sdroege
sdroege approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@sdroege sdroege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me otherwise

@bilelmoussaoui bilelmoussaoui force-pushed the bilelmoussaoui/gtk-more-manual-3 branch from 96fcdfa to 5b01b58 Compare March 22, 2021 09:35
@bilelmoussaoui
Copy link
Member Author

Thanks for the review @sdroege. Going to go ahead and merge this for now.

@bilelmoussaoui bilelmoussaoui merged commit 311af79 into master Mar 22, 2021
@bilelmoussaoui bilelmoussaoui deleted the bilelmoussaoui/gtk-more-manual-3 branch March 22, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdroege sdroege sdroege approved these changes

Assignees
No one assigned
Labels
gtk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bilelmoussaoui @sdroege