Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more manual stuff #213

Merged
merged 22 commits into from
Mar 22, 2021
Merged

more manual stuff #213

merged 22 commits into from
Mar 22, 2021

Commits on Mar 20, 2021

  1. Configuration menu
    Copy the full SHA
    3d8d4c1 View commit details
    Browse the repository at this point in the history
  2. gtk: ignore TreeModel::get

    we use TreeModel::get_value instead
    bilelmoussaoui committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    39bac63 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    00097d0 View commit details
    Browse the repository at this point in the history
  4. gtk: ignore ConstraintLayout::add_from_description

    we only need add_from_descriptionv
    bilelmoussaoui committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    f2620fd View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c6ab836 View commit details
    Browse the repository at this point in the history
  6. gtk: ignore TreeSelection::get_user_data

    it's unsafe and the caller can just use ffi if needed
    bilelmoussaoui committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    e57791b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2635b55 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6d99718 View commit details
    Browse the repository at this point in the history
  9. gtk: remove the hackish FileChooserDialog::new implementation

    instead of having a fixed number of buttons, just call add_buttons once we create
    the dialog
    bilelmoussaoui committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    a9b15e3 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2021

  1. Configuration menu
    Copy the full SHA
    8308184 View commit details
    Browse the repository at this point in the history
  2. gtk: manually implement Editable::install_properties

    The method is expected to be called in class_init, so handle it as EditableClassSubclassExt auto implemented trait
    bilelmoussaoui committed Mar 21, 2021
    Configuration menu
    Copy the full SHA
    8b22dca View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    086bfc2 View commit details
    Browse the repository at this point in the history
  4. gtk: manually implement MessageDialog markup methods

    From Rust you should rather call format! then pass the formatted string
    instead of using a weird C api.
    bilelmoussaoui committed Mar 21, 2021
    Configuration menu
    Copy the full SHA
    f802cc0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c54cf5a View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2021

  1. Configuration menu
    Copy the full SHA
    58de0a8 View commit details
    Browse the repository at this point in the history
  2. gtk: fix Editable subclassing support

    Mostly move stuff to EditableImpl instead of Editable
    bilelmoussaoui committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    b641844 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    441fc9d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a84696f View commit details
    Browse the repository at this point in the history
  5. gtk: manually implement TreeModel::get

    add an assertion for the column number that gets passed
    bilelmoussaoui committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    4781120 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    acd3f7e View commit details
    Browse the repository at this point in the history
  7. gtk: add a check on BoolFilter::[new|set_expression]

    BoolFilter's expression must be either NULL or evaluate to a boolean
    bilelmoussaoui committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    f3749c2 View commit details
    Browse the repository at this point in the history
  8. gtk: add a check on StringFilter::[new|set_expression]

    StringFilter's expression must be either NULL or evaluate to a string
    bilelmoussaoui committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    5b01b58 View commit details
    Browse the repository at this point in the history