-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop macos-14 runner as it's no longer x86 #1098
base: main
Are you sure you want to change the base?
Conversation
No need to use the macos-14 runner as it's not actually testing x86 anymore. Switching to just the macos-latest runner (silicon).
note that the x86_64 flag for macos-14 was actually incorrect
@@ -31,8 +31,6 @@ jobs: | |||
{ | |||
cibuildwheel --print-build-identifiers --platform linux --archs x86_64 \ | |||
| jq -nRc '{"only": inputs, "os": "ubuntu-latest"}' \ | |||
&& cibuildwheel --print-build-identifiers --platform macos --archs x86_64 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re: your comment on the other PR, this seems appropriate too, yes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed
Is there something in the nightly build too? Also |
Not that I noticed, but there is a non-zero chance I missed something 😅
Are you suggesting testing/building against one/both of these specifically rather than macos-latest? |
I was thinking we might want both, but it's not the highest priority if you have other things which are pressing. |
Agreed. Looks like the nightly build is bigger GPU things, not MacOS. |
I think we can come back to this! |
@riedgar-ms feel free to merge this if you approve it tomorrow :) |
No need to use the macos-14 runner as it's not actually testing x86 anymore. Switching to just the macos-latest runner (silicon).