Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop macos-14 runner as it's no longer x86 #1098

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hudson-ai
Copy link
Collaborator

No need to use the macos-14 runner as it's not actually testing x86 anymore. Switching to just the macos-latest runner (silicon).

No need to use the macos-14 runner as it's not actually testing x86 anymore. Switching to just the macos-latest runner (silicon).
@hudson-ai hudson-ai requested a review from riedgar-ms January 15, 2025 20:15
note that the x86_64 flag for macos-14 was actually incorrect
@@ -31,8 +31,6 @@ jobs:
{
cibuildwheel --print-build-identifiers --platform linux --archs x86_64 \
| jq -nRc '{"only": inputs, "os": "ubuntu-latest"}' \
&& cibuildwheel --print-build-identifiers --platform macos --archs x86_64 \
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re: your comment on the other PR, this seems appropriate too, yes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

@riedgar-ms
Copy link
Collaborator

Is there something in the nightly build too?

Also
https://github.com/actions/runner-images/blob/main/images/macos/macos-15-arm64-Readme.md
shows Macos-14-arm and macos-15-arm.

@hudson-ai
Copy link
Collaborator Author

Is there something in the nightly build too?

Not that I noticed, but there is a non-zero chance I missed something 😅

Also https://github.com/actions/runner-images/blob/main/images/macos/macos-15-arm64-Readme.md shows Macos-14-arm and macos-15-arm.

Are you suggesting testing/building against one/both of these specifically rather than macos-latest?

@riedgar-ms
Copy link
Collaborator

I was thinking we might want both, but it's not the highest priority if you have other things which are pressing.

@riedgar-ms
Copy link
Collaborator

Agreed. Looks like the nightly build is bigger GPU things, not MacOS.

@hudson-ai
Copy link
Collaborator Author

I was thinking we might want both, but it's not the highest priority if you have other things which are pressing.

I think we can come back to this!

@hudson-ai
Copy link
Collaborator Author

@riedgar-ms feel free to merge this if you approve it tomorrow :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants