Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop macos-14 runner as it's no longer x86 #1098

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Drop macos-14 runner as it's no longer x86 #1098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a1a1c9
Drop macos-14 runner as it's no longer x86
hudson-ai Jan 15, 2025
2ee41b8
furthermore stop building for macos-14
hudson-ai Jan 15, 2025
120a3a1
Merge branch 'main' into hudson-ai-patch-2
hudson-ai Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/pypi_upload.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ jobs:
{
cibuildwheel --print-build-identifiers --platform linux --archs x86_64 \
| jq -nRc '{"only": inputs, "os": "ubuntu-latest"}' \
&& cibuildwheel --print-build-identifiers --platform macos --archs x86_64 \
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re: your comment on the other PR, this seems appropriate too, yes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@riedgar-ms

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

| jq -nRc '{"only": inputs, "os": "macos-14"}' \
&& cibuildwheel --print-build-identifiers --platform macos --archs arm64 \
| jq -nRc '{"only": inputs, "os": "macos-latest"}' \
&& cibuildwheel --print-build-identifiers --platform windows --archs auto64 \
Expand Down
24 changes: 2 additions & 22 deletions .github/workflows/workflow-pr-gate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
bare-install:
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-14]
os: [ubuntu-latest, windows-latest, macos-latest]
python-version: ["3.9", "3.10", "3.11", "3.12"]
runs-on: ${{ matrix.os }}
steps:
Expand Down Expand Up @@ -113,28 +113,8 @@ jobs:

# Third Stage ==============================================================
# Windows and MacOS, plus other GPU Linux tests

basic-tests-mac-x86:
needs: end-stage-2
strategy:
fail-fast: false # Don't cancel all on first failure
matrix:
python-version: ["3.9", "3.10", "3.11", "3.12"]
model:
- "transformers_gpt2_cpu"
- "transformers_phi2_cpu"
# - "transformers_mistral_7b_cpu" See Issue 713
- "llamacpp_llama2_7b_cpu"
- "llamacpp_mistral_7b_cpu"
# - "transformers_phi3_mini_4k_instruct_cpu" Gives trouble on MacOS
- "llamacpp_phi3_mini_4k_instruct_cpu"
uses: ./.github/workflows/action_plain_basic_tests.yml
with:
os: macos-14
python-version: ${{ matrix.python-version }}
model: ${{ matrix.model }}

basic-tests-mac-arm:
basic-tests-mac:
needs: end-stage-2
strategy:
fail-fast: false # Don't cancel all on first failure
Expand Down
Loading