Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Baysor>=7.0.0 #127

Merged
merged 6 commits into from
Sep 25, 2024
Merged

Support Baysor>=7.0.0 #127

merged 6 commits into from
Sep 25, 2024

Conversation

quentinblampey
Copy link
Collaborator

Hi @lguerard, I added a test to check if the cell IDs are string
In the new 0.7.0 version, the cell IDs are strings, and we need to use the obs_names instead of CellID to compare to the loom matrix

Let me know if this works for you!

lguerard and others added 6 commits September 24, 2024 09:18
Latest version of Baysor outputs either `segmentation_polygons2D.json` or
`segmentation_polygons3D.json` depending on input data.
This very basic fix would reestablish compatibility, in case users aren't
running both 2D and 3D and outputting results in same folder
Some Baysor options were removed and the output format of the polygons needs to
be changed to fit with the next steps of the pipeline.
@quentinblampey
Copy link
Collaborator Author

Also, for now, you'll see that it doesn't support 3D segmentation. It will require additional updates to support it

@lguerard
Copy link
Contributor

Thanks a lot for looking into that !

And thank you for including the dask backend so make it easier to do parallelization. I just tried with write_patches_cells but I'm getting an error, I'm not familiar at all with dask so I'm not sure what it means..

RuntimeError: Can't redefine method: __getstate__ on class: __torch__.torch.utils.mkldnn.MkldnnBatchNorm (of Python compilation unit at: 000001A8C4E17ED0)

@quentinblampey
Copy link
Collaborator Author

Could you open an issue with a detailed error log?
Since I'll merge this PR soon, it will be better to keep track of this issue

@lguerard
Copy link
Contributor

I'm reinstalling my environment right now, I'll create an issue if I encounter it again.

But anyway, you removed the settings file and the dask support for now no ?

@quentinblampey
Copy link
Collaborator Author

quentinblampey commented Sep 25, 2024

Yes, I was making these changes in the dev branch, but now I have moved everything to the sopa2 branch.
Since these changes will be quite big, I decided to keep it for a future sopa==2.0.0 release

So you can try the sopa2 branch to test it out. Let me know!

NB: I saved the old tutorial as old_api_usage.ipynb to ensure backward compatibility (the old way to do it should still work), but you can try the api_usage.ipynb notebook (which is still in progress)

@quentinblampey
Copy link
Collaborator Author

Merging this PR, thanks @lguerard!
And please let me know regarding the issue with the dask parallelization (see my comment above)

@quentinblampey quentinblampey merged commit 02cf901 into dev Sep 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants