-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[query] Expose references via ExecuteContext
#14686
Open
ehigham
wants to merge
1
commit into
ehigham/py4j-backend-extensions
Choose a base branch
from
ehigham/ctx-references
base: ehigham/py4j-backend-extensions
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Sep 17, 2024
ehigham
force-pushed
the
ehigham/ctx-references
branch
2 times, most recently
from
September 17, 2024 15:47
3518244
to
e0b89a5
Compare
ehigham
force-pushed
the
ehigham/cloud-credentials
branch
from
September 19, 2024 20:52
9cff2fc
to
d14679d
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
September 19, 2024 20:52
92da6f0
to
4576acf
Compare
This was referenced Sep 20, 2024
ehigham
force-pushed
the
ehigham/cloud-credentials
branch
from
October 1, 2024 19:44
d14679d
to
ed2e8e8
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
October 1, 2024 19:44
4576acf
to
8a42e93
Compare
ehigham
force-pushed
the
ehigham/cloud-credentials
branch
from
October 8, 2024 19:18
ed2e8e8
to
fc06f02
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
October 8, 2024 19:18
341e6a7
to
1682964
Compare
ehigham
force-pushed
the
ehigham/cloud-credentials
branch
from
October 8, 2024 20:30
fc06f02
to
a101b55
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
October 8, 2024 20:30
1682964
to
b1c0d04
Compare
ehigham
force-pushed
the
ehigham/cloud-credentials
branch
from
October 16, 2024 20:02
a101b55
to
1682a0f
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
October 16, 2024 20:02
b1c0d04
to
84ddcf3
Compare
ehigham
force-pushed
the
ehigham/cloud-credentials
branch
from
October 16, 2024 21:30
1682a0f
to
6e63e69
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
October 16, 2024 21:30
84ddcf3
to
a2ff477
Compare
1 task
ehigham
force-pushed
the
ehigham/cloud-credentials
branch
from
October 17, 2024 14:59
6e63e69
to
d31f732
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
2 times, most recently
from
October 21, 2024 15:24
df5c723
to
adc0602
Compare
ehigham
force-pushed
the
ehigham/cloud-credentials
branch
from
October 21, 2024 18:50
82e6e7a
to
a70aa24
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
October 29, 2024 21:47
756ba40
to
539e25f
Compare
ehigham
force-pushed
the
ehigham/cloud-credentials
branch
from
October 31, 2024 15:47
4cf050e
to
01aedac
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
October 31, 2024 15:47
539e25f
to
2b266d0
Compare
ehigham
force-pushed
the
ehigham/cloud-credentials
branch
from
November 4, 2024 22:15
01aedac
to
6e36a7a
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
November 4, 2024 22:15
2b266d0
to
b069621
Compare
ehigham
force-pushed
the
ehigham/cloud-credentials
branch
from
November 19, 2024 17:08
6e36a7a
to
e121222
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
2 times, most recently
from
November 20, 2024 17:00
d229670
to
07a390d
Compare
This was referenced Dec 5, 2024
ehigham
force-pushed
the
ehigham/cloud-credentials
branch
from
December 12, 2024 21:51
d21ad57
to
0a14104
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
December 12, 2024 21:51
07a390d
to
234bda8
Compare
ehigham
force-pushed
the
ehigham/cloud-credentials
branch
from
December 12, 2024 22:00
0a14104
to
4b932f1
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
December 12, 2024 22:01
234bda8
to
92087ca
Compare
ehigham
force-pushed
the
ehigham/cloud-credentials
branch
from
December 12, 2024 22:02
4b932f1
to
64042bc
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
December 12, 2024 22:02
92087ca
to
d7df668
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
December 16, 2024 18:49
d7df668
to
a33bb7f
Compare
ehigham
changed the base branch from
main
to
ehigham/py4j-backend-extensions
December 16, 2024 18:49
ehigham
force-pushed
the
ehigham/py4j-backend-extensions
branch
from
December 17, 2024 16:47
b8b22b8
to
2d4edc1
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
December 17, 2024 16:47
a33bb7f
to
b19073d
Compare
ehigham
force-pushed
the
ehigham/py4j-backend-extensions
branch
from
December 17, 2024 20:00
2d4edc1
to
79ecea8
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
December 17, 2024 20:00
b19073d
to
75f4fd5
Compare
ehigham
force-pushed
the
ehigham/py4j-backend-extensions
branch
from
January 13, 2025 16:36
79ecea8
to
1d36659
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
January 13, 2025 16:36
75f4fd5
to
5c0308f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is split out from a larger refactoring effort on the various Backend
implementations. The goals of this effort are to provide query-level
configuration to the backend that's currently tied to the lifetime of a backend,
reduce code duplication and reduce state duplication.
In this change, I'm restoring references to the execute context [1] and
decoupling them from the backend. In a future change, they'll be lifted out of
the backend implementations altogether. This is to reduce the surface area of
the Backend interface to the details that are actually different.
Both the Local and Spark backend have state that's manipulated from python via
various py methods. These pollute the Backend interface [2] and so have been
extracted into the trait Py4JBackendExtensions. In future changes, this will
become a facade that owns state set in python.
Notes
[1] "Restoring" old behaviour I foolishly removed in fe5ed32
[2] "Pollute" in that they obfuscate what's different about backend query plan
and execution