Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow template-haskell version 2.22 #595

Merged
merged 1 commit into from
May 17, 2024

Conversation

BebeSparkelSparkel
Copy link
Contributor

No description provided.

Copy link
Contributor

@Bodigrim Bodigrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is trivial, let me merge without a second review.

@Bodigrim Bodigrim merged commit dda7fc6 into haskell:master May 17, 2024
27 checks passed
@phadej
Copy link
Contributor

phadej commented May 17, 2024

I'm confused. GHC-9.10.1 ships with th-2.22 and text-2.1.1. The https://hackage.haskell.org/package/text-2.1.1/revisions/ was applied two days ago.

Did GHC ship with some unversioned commit of text?

@Bodigrim
Copy link
Contributor

Shipping unversioned commit would be more or less fine, it happens all the time, but GHC was apparently shipped with a commit completely missing from upstream repo, which is quite undesirable.

@phadej
Copy link
Contributor

phadej commented May 17, 2024

By unversioned I meant "not in the version control system" (i.e. not untagged)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants