[Style] Addition of the support of background-image-repeat #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this seems great, one thing, im currently working on fixing the scaling in heaps, and im fairly sure, its going to conflict with this. Hopefully it will be easy to sort out... :/ |
|
So yeah, as expected, it conflicts now... :/ Might be easier to just pull latest and reimplement (sorry!) |
|
Sure ! |
|
There was no real conflict, actually, just a simple merge to do ! \o/ |
|
Thats reverting my changes though |
|
eg:
|
|
Ah ! My bad, I probably missed something in the VSCode UI, somehow. I'll fix it in a few days, when I'll be back home. Sorry :(
…________________________________
De : Ian Harrigan ***@***.***>
Envoyé : mercredi 22 mars 2023 16:28
À : haxeui/haxeui-heaps ***@***.***>
Cc : tfabretti ***@***.***>; Author ***@***.***>
Objet : Re: [haxeui/haxeui-heaps] [Style] Addition of the support of background-image-repeat (PR #40)
Thats reverting my changes though
—
Reply to this email directly, view it on GitHub<#40 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AENQVZ4SZLMYXQOTKBX2Z7TW5MLAPANCNFSM6AAAAAAWDVNIWE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to the issue #39
The paintTileRepeat function could be shorter but I wanted to avoid having a test for each image to check if it's in the last column/line, in case there are a lot of images to draw. Thus, it's longer but it's supposed to be slightly more optimized (it's probably not noticeable in the extreme majority of use cases, though).