Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the numpy dtype in get_type if the array is empty #318

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Mar 20, 2020

Motivation

Fix issue identified in oruebel/ndx-icephys-meta#57 with validating empty datasets. This is triggered in the icephys extension because it may use an empty DynamicTable (with just and id column) resulting in an empty columns dataset.

How to test the behavior?

See oruebel/ndx-icephys-meta#57 (comment)

Checklist

  • Have you checked our Contributing document?
  • Have you ensured the PR description clearly describes problem and the solution?
  • Is your contribution compliant with our coding style ? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using #XXX notation where XXX is the issue number ? By including "Fix #XXX" you allow GitHub to close the corresponding issue.

@oruebel oruebel requested a review from rly March 20, 2020 05:36
@codecov
Copy link

codecov bot commented Mar 20, 2020

Codecov Report

Merging #318 into dev will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #318      +/-   ##
==========================================
- Coverage   72.74%   72.72%   -0.03%     
==========================================
  Files          33       33              
  Lines        6436     6438       +2     
  Branches     1409     1410       +1     
==========================================
  Hits         4682     4682              
- Misses       1327     1328       +1     
- Partials      427      428       +1     
Impacted Files Coverage Δ
src/hdmf/validate/validator.py 70.90% <33.33%> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9da9162...ecf2a0a. Read the comment docs.

@oruebel
Copy link
Contributor Author

oruebel commented Feb 23, 2022

@rly I'm not sure whether the changes that are on the dev branch fix this issue. If yes, then we should just close this PR and issue.

It looks like #319 is trying to fix the same issue, so I guess this PR can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants