Fix bug on gettype on empty array, add validator tests #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that something is going wrong with differentiating the YAML: shape:
- nullfrom: shape: nullNo need to review yet. I will patch this up. |
|
The error in PyNWB is due to |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #317. Supersedes fix in #318. Closes #318. Adds a bunch of missing tests for validating the data type and shape of a dataset or attribute.
Fix issue identified in oruebel/ndx-icephys-meta#57 with validating empty datasets. This is triggered in the icephys extension because it may use an empty
DynamicTable(with just and id column) resulting in an empty columns dataset.How to test the behavior?
See oruebel/ndx-icephys-meta#57 (comment)