E301 has been further split into E305, E306 #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myint
requested changes
Nov 19, 2016
| @@ -196,6 +196,8 @@ def qualify_by_address( | |||
| params_to_check=frozenset(QUALIF_BY_ADDRESS_PARAM)): | |||
| """ This gets called by the web server """ | |||
| #: E129 | |||
|
|
|||
There was a problem hiding this comment.
The two empty lines should go before the comment.
|
Hi, It seems this issue has been dormant for over 2 months now. Is there anything I could help to move things forward? One thing I've noticed is that, if we split the issues (E306, E305) into separate task, it may help out things a bit, because E306 is more straight forward and does not introduce any breaking changes (I've tested with Python 2.7.10 and 3.5.1) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@myint
Continuing #283