Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all legacy notification/subscription models #9068

Merged
merged 16 commits into from
Sep 5, 2024

Conversation

timolegros
Copy link
Collaborator

@timolegros timolegros commented Aug 29, 2024

Link to Issue

Closes: #8998
Closes: #7738

Description of Changes

  • Removes Notifications, NotificationsRead, Subscriptions, and NotificationCategories tables/models
  • Removes has_chain_events_listener and max_notif_id columns

Test Plan

Deployment Plan

Other Considerations

@timolegros timolegros marked this pull request as ready for review August 30, 2024 11:03
@timolegros timolegros marked this pull request as draft August 30, 2024 11:04
@timolegros
Copy link
Collaborator Author

This PR will remain in draft until #9066 is merged.

# Conflicts:
#	libs/model/src/models/thread.ts
#	libs/model/src/thread/GetBulkThread.query.ts
#	packages/commonwealth/server/api/threads.ts
#	packages/commonwealth/server/controllers/server_communities_methods/create_community.ts
@timolegros timolegros marked this pull request as ready for review September 4, 2024 16:04
Copy link
Collaborator

@jnaviask jnaviask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge

@timolegros timolegros merged commit dca10c0 into master Sep 5, 2024
8 of 9 checks passed
@timolegros timolegros deleted the tim/remove-legacy-notif-sub-models branch September 5, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Legacy Notification/Subscription Models Delete legacy notifications
3 participants