Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed unnecessary wallet connect popup for contests #9089

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Fixed unnecessary wallet connect popup for contests #9089

merged 2 commits into from
Sep 3, 2024

Conversation

mzparacha
Copy link
Contributor

@mzparacha mzparacha commented Aug 30, 2024 •
edited
Loading

Link to Issue

Closes: #9036

Description of Changes

Fixed unnecessary wallet connect popup for contests

"How We Fixed It"

N/A

Test Plan

  1. Enable contests in a community
  2. Visit a community topic that has contest enabled
  3. Verify you don't see unnecessary metamask/wallet connect popups
  4. Change wallet network to something else
  5. Verify 3 again

Deployment Plan

N/A

Other Considerations

Unsure if the changes fully fix the issue (wasn't able to get enough test sepolia from alchemy to create contests).

@github-actions github-actions bot marked this pull request as draft August 30, 2024 17:26
@mzparacha mzparacha self-assigned this Aug 30, 2024
@mzparacha mzparacha marked this pull request as ready for review August 30, 2024 17:26
masvelio
masvelio approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@masvelio masvelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me. Would like @ianrowan to take a look at it, as ContractBase is pretty much top level class. But I clicked around and it looks good in the app

@masvelio masvelio requested a review from ianrowan September 3, 2024 11:46
ianrowan
ianrowan approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@ianrowan ianrowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and appears to work

ilijabojanovic
ilijabojanovic approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@ilijabojanovic ilijabojanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilijabojanovic ilijabojanovic merged commit df73a14 into master Sep 3, 2024
9 checks passed
@ianrowan ianrowan mentioned this pull request Sep 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianrowan ianrowan ianrowan approved these changes

@masvelio masvelio masvelio approved these changes

@ilijabojanovic ilijabojanovic ilijabojanovic approved these changes

@jnaviask jnaviask Awaiting requested review from jnaviask

Assignees

@mzparacha mzparacha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Wallet connect sign in modal continually pops up and makes navigating common impossible
4 participants
@mzparacha @ilijabojanovic @masvelio @ianrowan