Make OCaml code samples closer to Haskell (chapters 1 to 4) #242

yawaramin · 2020-02-20T05:18:37Z

Get rid of module declarations
Use only OCaml Stdlib
Rename composition operator to (%) due to operator precedence issues

- Get rid of module declarations - Use only OCaml Stdlib - Rename composition operator to `(%)` due to operator precedence issues

ArulselvanMadhavan · 2020-03-02T22:09:22Z

src/content/1.2/code/ocaml/snippet05.ml

@@ -1 +1,14 @@
-let fact n = List.fold (List.range 1 n) ~init:1 ~f:( * )
+(* OCaml doesn't ship with a lazy sequence range syntax nor a product


👍 I think I used Janestreet libs in a few places to reduce the snippet size and to move ahead quickly, but thanks for removing the dependency!

ArulselvanMadhavan · 2020-03-02T22:09:57Z

src/content/1.3/code/ocaml/snippet01.ml

@@ -1,6 +1,6 @@
-module type Monoid = sig
-  type a
+module type MONOID = sig


Is it an OCaml convention to capitalize the module type?

Hi yes I believe so, e.g. see http://www.mseri.me/typeclass-ocaml/

I will try to follow the ocaml conventions writing capitalized modules (e.g. Monoid) and fully capital signatures (e.g. MONOID).

the convention originates from SML, it's loosely followed in OCaml really (even stdlib doesn't follow it).

ArulselvanMadhavan · 2020-03-02T22:11:02Z

src/content/1.4/code/ocaml/snippet04.ml

@@ -1 +1,4 @@
-let pure x = x, ""
+let ( >=> ) m1 m2 = fun x ->


The snippets are starting to diverge here but I hope they are in the right place in the book

Indeed, the best way would probably be to run the LaTeX compilation and check the output, but from reading along the chapter I believe the sequence of the code samples now makes sense.

ArulselvanMadhavan · 2020-03-02T22:15:32Z

Even if we haven't reached a conclusion on whether we should write compilable snippets, I still think the changes in this PR, especially the ones that remove dependency on external libraries, are important. Thanks for fixing the order @yawaramin! I don't know when/how they got out of order

cc: @mseri @XVilka

yawaramin · 2020-03-03T02:45:59Z

Thanks @ArulselvanMadhavan I can work on more chapters as well, am enjoying reading through the book.

XVilka · 2020-03-03T03:10:56Z

Looks much cleaner and easier to read, indeed 👍

mseri · 2020-03-03T06:48:47Z

I agree. Looks good. Thanks @yawaramin

yawaramin · 2020-03-03T07:08:58Z

Cheers guys, I appreciate the review 👍

fhammerschmidt · 2020-03-30T06:52:21Z

Will this be merged? If so I will adapt the examples accordingly in my Reason branch, too.

JasoonS · 2020-03-30T15:21:09Z

src/content/1.1/code/ocaml/snippet02.ml

@@ -1,6 +1 @@
-module type Polymorphic_Function_G = sig


It was definitely confusing for me when I started going through the ocaml book (as an ocaml beginner when I saw these modules). 👍

hmemcpy · 2020-03-30T15:24:51Z

Sorry for not attending to this. Are there more changes coming? Also, does this tie to the prelude discussion in #237?

yawaramin · 2020-03-30T15:42:52Z

@hmemcpy hi, no problem. I've made some progress on Chapter 5 locally, if there is interest I can send more as I cover more chapters. It will be a good distraction for me from constantly obsessing over the news :-)

hmemcpy · 2020-03-30T15:44:25Z

I think a distraction would be welcomed for everybody!

francoisthire · 2020-05-29T22:26:42Z

What is the current status of this MR? Is there a way to help? What about the other chapters?

yawaramin · 2020-05-29T22:56:25Z

@hmemcpy would you prefer this PR to cover the whole book? Or separate PRs for a few chapters at a time?

hmemcpy · 2020-09-04T17:33:47Z

Hey all! So sorry for neglecting the PR! Would love to merge it. Can any of you verify there are no more changes? Unless you'd like to contribute the rest of the chapters as well?

drupol · 2022-05-17T11:54:38Z

Hi, what's the status of this PR ?

hyphenrf · 2022-10-29T18:25:53Z

src/content/1.1/code/ocaml/snippet03.ml

-    (G : Polymorphic_Function_G with type b = F.b) =
-struct
-  (** OCaml doesn't have a compose operator. So, creating one. **)
-  let ( >> ) g f x = g (f x)


this was confusing because earlier F#'s chevron operator was mentioned which is the same >> operator but encodes forward composition. I have no idea why these examples were so excessively verbose! This isn't a good impression of the language's expressiveness

ok so I've read earlier issues that explain why it was this verbose. interesting POVs.

hyphenrf · 2022-10-29T18:37:29Z

src/content/1.2/code/ocaml/snippet05.ml

+  | Seq.Cons (n, seq) -> product (result * n) seq
+let product = product 1
+
+let fact n = product (range 1 n)


why not just

let factorial n = Seq.fold_left ( * ) 1 (Seq.init n succ)

or

let product = Seq.fold_left ( * ) 1 let factorial n = Seq.init n succ |> product

or use List instead of Seq (at your choice, in case you prefer to be more backwards-compatible) ?
It doesn't really matter that it's "lazy" does it? At least the book doesn't seem to make a point out of it.

hyphenrf · 2022-10-29T18:38:01Z

src/content/1.2/code/ocaml/snippet06.ml

@@ -1,3 +1,2 @@
 type void


type void = |

or just use the word void directly, it's not like the haskell snippet has import Data.Void (Void, absurd)

hyphenrf · 2022-10-29T18:44:09Z

src/content/1.3/code/ocaml/snippet01.ml

@@ -1,6 +1,6 @@
-module type Monoid = sig
-  type a
+module type MONOID = sig


the convention originates from SML, it's loosely followed in OCaml really (even stdlib doesn't follow it).

hyphenrf · 2022-10-29T18:49:03Z

src/content/1.4/code/ocaml/snippet06.ml

- fun s -> String.split s ~on:' ', "to_words "
-;;
+(* val up_case : string -> string writer
+   Note: OCaml strings are raw bytestrings, not UTF-8 encoded. *)


The book never mentions UTF-8 encoding.. Maybe this makes sense in an OCaml tutorial to note, but why here?

hyphenrf · 2022-10-29T19:08:05Z

@yawaramin I'm reading the book right now, and I'm happy to help if you're still working on this. If not, I can take it from here and revise the rest of the chapters.

yawaramin · 2022-10-30T05:06:02Z

@hyphenrf hey that would be great, please feel free. I agree with all your comments btw.

drupol · 2023-02-02T10:39:14Z

Hi all,

What is the status of this PR ?

Thanks

hyphenrf · 2023-02-02T13:00:41Z

hi @drupol, I haven't finished reading the book. I have notes written all over the OCaml impl, and once I've finished the book, I'll create a patch with all the edits and which closes this PR.

drupol · 2023-02-02T13:01:36Z

Cool, glad to see it's still alive then.

Looking forward for reviewing your pull request.

Cheers!

Make OCaml code samples closer to Haskell (chapters 1 to 4)

67b94c4

- Get rid of module declarations - Use only OCaml Stdlib - Rename composition operator to `(%)` due to operator precedence issues

yawaramin mentioned this pull request Feb 20, 2020

Omit module declarations in OCaml snippets #237

Open

ArulselvanMadhavan reviewed Mar 2, 2020

View reviewed changes

JasoonS reviewed Mar 30, 2020

View reviewed changes

fhammerschmidt mentioned this pull request Sep 9, 2020

ReasonML edition. #247

Merged

hyphenrf reviewed Oct 29, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make OCaml code samples closer to Haskell (chapters 1 to 4) #242

Make OCaml code samples closer to Haskell (chapters 1 to 4) #242

yawaramin commented Feb 20, 2020

ArulselvanMadhavan Mar 2, 2020

ArulselvanMadhavan Mar 2, 2020

yawaramin Mar 3, 2020

hyphenrf Oct 29, 2022

ArulselvanMadhavan Mar 2, 2020

yawaramin Mar 3, 2020

ArulselvanMadhavan commented Mar 2, 2020

yawaramin commented Mar 3, 2020

XVilka commented Mar 3, 2020

mseri commented Mar 3, 2020

yawaramin commented Mar 3, 2020

fhammerschmidt commented Mar 30, 2020

JasoonS Mar 30, 2020

hmemcpy commented Mar 30, 2020

yawaramin commented Mar 30, 2020

hmemcpy commented Mar 30, 2020

francoisthire commented May 29, 2020

yawaramin commented May 29, 2020

hmemcpy commented Sep 4, 2020

drupol commented May 17, 2022

hyphenrf Oct 29, 2022 •

edited

Loading

hyphenrf Oct 29, 2022

hyphenrf Oct 29, 2022

hyphenrf Oct 29, 2022

hyphenrf Oct 29, 2022

hyphenrf Oct 29, 2022

hyphenrf commented Oct 29, 2022

yawaramin commented Oct 30, 2022

drupol commented Feb 2, 2023

hyphenrf commented Feb 2, 2023

drupol commented Feb 2, 2023

		@@ -1 +1,14 @@
		let fact n = List.fold (List.range 1 n) ~init:1 ~f:( * )
		(* OCaml doesn't ship with a lazy sequence range syntax nor a product

Make OCaml code samples closer to Haskell (chapters 1 to 4) #242

Are you sure you want to change the base?

Make OCaml code samples closer to Haskell (chapters 1 to 4) #242

Conversation

yawaramin commented Feb 20, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ArulselvanMadhavan commented Mar 2, 2020

yawaramin commented Mar 3, 2020

XVilka commented Mar 3, 2020

mseri commented Mar 3, 2020

yawaramin commented Mar 3, 2020

fhammerschmidt commented Mar 30, 2020

Choose a reason for hiding this comment

hmemcpy commented Mar 30, 2020

yawaramin commented Mar 30, 2020

hmemcpy commented Mar 30, 2020

francoisthire commented May 29, 2020

yawaramin commented May 29, 2020

hmemcpy commented Sep 4, 2020

drupol commented May 17, 2022

hyphenrf Oct 29, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hyphenrf commented Oct 29, 2022

yawaramin commented Oct 30, 2022

drupol commented Feb 2, 2023

hyphenrf commented Feb 2, 2023

drupol commented Feb 2, 2023

hyphenrf Oct 29, 2022 •

edited

Loading