Skip to content

Commit

Permalink
Merge pull request #969 from hmrc/DL-8837-3
Browse files Browse the repository at this point in the history
Remove unnecicarry query params
  • Loading branch information
scott-goodwin authored Dec 13, 2022
2 parents 7fd5725 + c0ab11f commit 2d0d64e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion app/v1/connectors/PenaltiesConnector.scala
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ class PenaltiesConnector @Inject()(val http: HttpClient,
correlationId: String): Future[Outcome[FinancialDataResponse]] = {
val vrn = request.vrn.vrn
val searchItem = request.searchItem
val url = appConfig.penaltiesBaseUrl + s"/penalties/penalty/financial-data/VRN/$vrn/VATC?searchType=CHGREF&searchItem=${searchItem}&includeClearedItems=true&includeStatistical=false&includePaymentOnAccount=true&addRegimeTotalisation=false&addLockInformation=false&addPenaltyDetails=false&addPostedInterestDetails=true&addAccruingInterestDetails=true"
val url = appConfig.penaltiesBaseUrl + s"/penalties/penalty/financial-data/VRN/$vrn/VATC?searchType=CHGREF&searchItem=${searchItem}"


def doGet(implicit hc: HeaderCarrier): Future[Outcome[FinancialDataResponse]] = {
Expand Down
2 changes: 1 addition & 1 deletion test/v1/constants/FinancialDataConstants.scala
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ object FinancialDataConstants {

def financialDataUrl(vrn: String = vrn)(implicit appConfig: AppConfig): String = s"/penalties/penalty/financial-data/VRN/$vrn/VATC"

def financialDataUrlWithConfig(vrn: String = vrn)(implicit appConfig: AppConfig): String = appConfig.penaltiesBaseUrl + s"/penalties/penalty/financial-data/VRN/$vrn/VATC?searchType=CHGREF&searchItem=${searchItem}&includeClearedItems=true&includeStatistical=false&includePaymentOnAccount=true&addRegimeTotalisation=false&addLockInformation=false&addPenaltyDetails=false&addPostedInterestDetails=true&addAccruingInterestDetails=true"
def financialDataUrlWithConfig(vrn: String = vrn)(implicit appConfig: AppConfig): String = appConfig.penaltiesBaseUrl + s"/penalties/penalty/financial-data/VRN/$vrn/VATC?searchType=CHGREF&searchItem=${searchItem}"


val testDownstreamFinancialDetailsNoDocumentDetails: JsValue = {
Expand Down

0 comments on commit 2d0d64e

Please sign in to comment.