Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ChatInput and Status components #69

Merged
merged 6 commits into from
Oct 20, 2023
Merged

Conversation

MarcSkovMadsen
Copy link
Collaborator

As discussed in holoviz/panel#5670, moves the ChatInput and Status components to panel-chat-examples where they can live until Panel gets similar built in components.

@MarcSkovMadsen
Copy link
Collaborator Author

MarcSkovMadsen commented Oct 19, 2023

The two failing tests are due to mistral_and_llama png and mo4. I can see that it tries to merge all the files related to widget -> chat change. I don't think I've caused that. Do you know why it looks like that @ahuang11 ?

@ahuang11
Copy link
Collaborator

Thanks for reporting that; it should be fixed in #70

@ahuang11
Copy link
Collaborator

ahuang11 commented Oct 19, 2023

These are probably very useful chat components, and on second thought, I suppose if we have it here, it wouldn't have as much visibility as in the official Panel reference gallery. Also, with these components, I suppose this repo shouldn't be called panel-chat-examples, and lastly, it's not easily pip installable since this package isn't published to PyPi.

However, I suppose they could first live in this repo if you'd like, but once they are here, I'd like to see a PR made to Panel.

@MarcSkovMadsen
Copy link
Collaborator Author

Agree. Right now they are here panel-chat-examples provide a temporary home. We can iterate on them here and get some community feedback. When/ if more is done they can be moved to panel or another panel-xyz package.

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (13f7e6e) 98.41% compared to head (63787a1) 78.88%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #69       +/-   ##
===========================================
- Coverage   98.41%   78.88%   -19.54%     
===========================================
  Files           2        5        +3     
  Lines          63      161       +98     
===========================================
+ Hits           62      127       +65     
- Misses          1       34       +33     
Files Coverage Δ
panel_chat_examples/components/__init__.py 100.00% <100.00%> (ø)
panel_chat_examples/components/chat_input.py 90.00% <90.00%> (ø)
panel_chat_examples/components/status.py 58.66% <58.66%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcSkovMadsen
Copy link
Collaborator Author

MarcSkovMadsen commented Oct 20, 2023

This PR also includes changes to the autogenerated files due to #71.

@ahuang11 . I believe this should be ready to merge. Otherwise let me know what to do. Thanks.

@ahuang11 ahuang11 force-pushed the enhancement/streamlit-components branch from 63787a1 to 7a800e7 Compare October 20, 2023 17:31
@ahuang11 ahuang11 merged commit 9d38b00 into main Oct 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants