-
-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Streamlit Chat Migration Guide #5670
Conversation
Not super convinced that we should add the ChatInput and ChatStatus examples. |
Codecov Report
@@ Coverage Diff @@
## main #5670 +/- ##
==========================================
- Coverage 84.10% 84.10% -0.01%
==========================================
Files 288 288
Lines 41990 41984 -6
==========================================
- Hits 35317 35309 -8
- Misses 6673 6675 +2
Flags with carried forward coverage won't be shown. Click here to find out more. see 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Questions
|
I assume its because the components code are long and not for beginners? But since we dont have those components in Panel today, how do we guide users wanting to migrate? |
If we have a ChatInput, I'd like it to be like the GitHub text box which lets users input both text and files by drag/drop.
Isn't ChatInput equivalent to TextInput at the moment? |
We definitely want a full featured
I think it's much better to either skip that or say that we are working on it than scaring the user with a huge wall of text. |
TextInput is What we have at the moment. But they are not equivalent.
The ChatInput is easier to use when submitting multiple messages. I think we carve out the advanced ChatInput you have implemented in the ChatInterface and Expose that @ahuang11 |
Maybe in the future; I wouldn't want to hold up the Panel release any longer. Perhaps track it in a new issue? |
Agree that we should not hold up the Panel release. My suggestion would be to
We could optionally
What do you think? |
I like the idea of both. |
I've moved the |
Assetsstreamlit_callback_handler.mp4panel_callback_handler.mp4 |
This one is ready for review @philippjfr . I cannot request it from you as you opened the PR. |
Thx |
Supersedes #5642
PanelCallbackHandler
example depends on this.