Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved: Replace externalFacilityId with facilityId in payload & increase the viewSize to 250 (#289) #290

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Improved: Replace externalFacilityId with facilityId in payload & increase the viewSize to 250 (#289) #290

merged 1 commit into from
Jul 17, 2024

Conversation

R-Sourabh
Copy link
Contributor

@R-Sourabh R-Sourabh commented Jun 13, 2024 •
edited
Loading

Related Issues

#289

Short Description and Why It's Useful

  • Replaced the externalFacilityId with facilityId while creating the shipment.
  • Also replaced the payload parameter from externalDestinationFacilityId to destinationFacilityId.
  • Increased the viewSize while fetching the facilities from 50 to 250.

Contribution and Currently Important Rules Acceptance

@R-Sourabh R-Sourabh changed the title Updated: Replace externalFacilityId with facilityId in payload & increase the viewSize to 250 (#289) Improved: Replace externalFacilityId with facilityId in payload & increase the viewSize to 250 (#289) Jul 9, 2024
@ymaheshwari1 ymaheshwari1 merged commit c83e525 into hotwax:main Jul 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymaheshwari1 ymaheshwari1 ymaheshwari1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@R-Sourabh @ymaheshwari1